New regexp settings to close issue from a commit (OD-166)
bufferUnderrun opened 6 years ago

Hi,

Story

Actually, we can close an issue by using the hardcoded convention in a commit :

[fix|fixing|fixed|resolve|resolving|resolved] issue #[issue number] [:optional issue description]

If it works as expected, this workflow can be confusing as our git history look like we are only fixing issues whereas we are also working on new "features".

2020 06 29 18 08 35 MINGW64  C Www PassePortLoisirs Src

Improvement

This regexp should be a config parameter in settings. So, we could set this regexp for our personal use case :

[fix|close] [bug|feature] #[issue number] [:optional issue description]

Thanks

  • OneDev changed state to 'Closed' 6 years ago
    Previous Value Current Value
    Open
    Closed
  • Robin Shen commented 6 years ago

    At this point, I think we do not need to make this pattern customizable. Just add verb "close/closed/closing/closes" should be sufficient.

  • Robin Shen changed iterations 6 years ago
    Previous Value Current Value
    empty
    3.2.2
  • OneDev changed state to 'Released' 6 years ago
    Previous Value Current Value
    Closed
    Released
  • bufferUnderrun changed state to 'Open' 6 years ago
    Previous Value Current Value
    Released
    Open
  • bufferUnderrun commented 6 years ago

    For me "Issue" is a synonym of "problem" and using this word when talking about a new feature is not correct. The git history have to be precise on each commit.

    When i create a new issue (the perfect word would be "ticket") and set the type "Feature". Later when i achieve the code, i push commit as "add feature #123 : short desc message" and i'm expecting the issue #123 to close. "fix issue #123" is not consistent.

    Could you add the term "feature" ?

    Thanks

  • Robin Shen commented 6 years ago

    Understand. Will think about this...

  • Robin Shen commented 6 years ago

    Implementing this will cause a lot trouble as OneDev has to support this in all places referencing issues (markdown/commit message/title etc) to make the term consistent.

    Also when click the "reference issue" button in markdown menu, it will insert "issue #..." in case user does not know the referencing pattern. If this is configurable, OneDev does not what proper term to insert then.

    Considering all the problems it causes, I'd like not to change it right now.

  • Robin Shen changed state to 'Closed' 6 years ago
    Previous Value Current Value
    Open
    Closed
  • bufferUnderrun changed title 3 years ago
    Previous Value Current Value
    New regexp settings to close issue from acommit
    New regexp settings to close issue from a commit
  • ShalokShalom commented 3 years ago

    We could simply change the term to ticket, and everybody is happy?

  • Robin Shen commented 3 years ago

    As mentioned above. The change is not trivial, and let's just use the same term as GitHub/GitLab.

  • ShalokShalom commented 3 years ago

    ok ????

issue 1/1
Type
Improvement
Priority
Normal
Assignee
Iterations
Issue Votes (0)
Watchers (3)
Reference
OD-166
Please wait...
Connection lost or session expired, reload to recover
Page is in error, reload to recover