bufferUnderrun opened 4 years ago
|
|||||
OneDev changed state to 'Closed' 4 years ago
|
|||||
At this point, I think we do not need to make this pattern customizable. Just add verb "close/closed/closing/closes" should be sufficient. |
|||||
Robin Shen changed milestones 4 years ago
|
|||||
OneDev changed state to 'Released' 4 years ago
|
|||||
bufferUnderrun changed state to 'Open' 4 years ago
|
|||||
For me "Issue" is a synonym of "problem" and using this word when talking about a new feature is not correct. The git history have to be precise on each commit. When i create a new issue (the perfect word would be "ticket") and set the type "Feature". Later when i achieve the code, i push commit as "add feature #123 : short desc message" and i'm expecting the issue #123 to close. "fix issue #123" is not consistent. Could you add the term "feature" ? Thanks |
|||||
Understand. Will think about this... |
|||||
Implementing this will cause a lot trouble as OneDev has to support this in all places referencing issues (markdown/commit message/title etc) to make the term consistent. Also when click the "reference issue" button in markdown menu, it will insert "issue #..." in case user does not know the referencing pattern. If this is configurable, OneDev does not what proper term to insert then. Considering all the problems it causes, I'd like not to change it right now. |
|||||
Robin Shen changed state to 'Closed' 4 years ago
|
|||||
bufferUnderrun changed title 1 year ago
|
|||||
bufferUnderrun referenced from other issue 1 year ago
|
|||||
We could simply change the term to ticket, and everybody is happy? |
|||||
As mentioned above. The change is not trivial, and let's just use the same term as GitHub/GitLab. |
|||||
ok ???? |
Hi,
Story
Actually, we can close an issue by using the hardcoded convention in a commit :
If it works as expected, this workflow can be confusing as our git history look like we are only fixing issues whereas we are also working on new "features".
Improvement
This regexp should be a config parameter in settings. So, we could set this regexp for our personal use case :
Thanks