Michael Weimann
opened 6 years ago
-
Previous Value Current Value PR: File changes doesn't update source branch
PR: File changes do not update if source branch has new commits
-
Reproducing PR: https://onedev.io/projects/michael.test/pulls/1/changes
- test branch created
- PR test -> master opened
- README in master edited
- merged master into test
-
Pull request changes is currently calculated by comparing source branch against target branch at the time of creating pull request. I agree that it should be more natural to compare against latest of target branch.
Need to investigate it further as some other features such as code comments and review statuses are built upon this assumption.
-
Uff - this is a quite weird behaviour.
In my test project merges are common.The only way reviewing changes is by looking at the "merge preview".
But there it is not possible to comment :/ -
Name Previous Value Current Value Iterations
empty 3.1.2
-
Previous Value Current Value PR: File changes do not update if source branch has new commits
Pull request file changes should compare with latest head of target branch
-
Name Previous Value Current Value Type
Bug
Improvement
-
OneDev
changed state to 'Closed' 6 years ago
Previous Value Current Value Open
Closed
-
👍
-
Previous Value Current Value Closed
Open
-
The state "Closed" in code.onedev.io now means the issue is closed but not released yet. Have you observed incorrect behavior of this fix on master branch?
-
Previous Value Current Value Open
Closed
-
Change state to "Closed" as work on this issue is done.
-
OneDev
changed state to 'Released' 6 years ago
Previous Value Current Value Closed
Released
-
OneDev
referenced from other issue 6 years ago
What I did:
Expected: "Master merge" changes are not displayed as changes