-
13 hours ago
-
The functional behavior is consistent across the side-info layouts, but the patch currently fails
git diff --checkbecause of newly introduced trailing and mixed indentation whitespace. Please clean up the flagged lines before merge. -
-
13 hours ago
-
Reviewed the current patch. The prior whitespace concern is resolved,
git diff --checkpasses, and the wide-screen collapse logic preserves narrow-screen andhide-side-infooverlay behavior. Maven compilation could not be run because neithermvnnor a Maven wrapper is available in this environment. -
-
9 hours ago
-
The latest commit reintroduces whitespace errors in
side-info.js, as detailed inline. Please clean up both flagged lines sogit diff --checkpasses. -
-
9 hours ago
-
Reviewed the current head. The earlier whitespace regression is fixed:
git diff --checkpasses, and the wide-screen collapse state and trigger synchronization preserve overlay-only click-outside and Escape behavior. No blocking issues found. Maven compilation could not be rerun because neithermvnnor a Maven wrapper is available in this environment. -
-
8 hours ago
-
Changes requested: viewport transitions currently carry the wrong
closedstate across the pinned/overlay breakpoint, causing an open overlay after narrowing and preventing saved/default pinned visibility from being restored after widening.git diff --checkand JavaScript syntax validation pass. -
-
8 hours ago
-
The breakpoint-state synchronization is fixed, but wide-screen keyboard collapse remains broken: Escape is restricted to overlay mode. Please restore Escape closing for pinned panes.
git diff --checkand JavaScript syntax validation pass; Maven is unavailable in this environment. -
-
8 hours ago
-
Restored Escape closing for wide pinned side-info panes. Click-outside close remains limited to overlay mode.
-
@cwh Escape should be disabled for pinned mode. Also please explain more for this problem:
Changes requested: viewport transitions currently carry the wrong closed state across the pinned/overlay breakpoint, causing an open overlay after narrowing and preventing saved/default pinned visibility from being restored after widening. git diff --check and JavaScript syntax validation pass.
-
The latest fix restores Escape closing for both pinned and overlay side-info panes while keeping click-outside closing limited to overlay mode. Breakpoint transitions preserve the saved/default pinned visibility state.
git diff --checkand JavaScript syntax validation pass; no blocking issues found. Maven compilation was not available because neither Maven nor a Maven wrapper is installed in this environment. -
-
8 hours ago
-
Addressed the latest concern: Escape is again limited to overlay mode, so pinned panes only collapse through the explicit controls.
The earlier breakpoint bug came from treating the DOM
closedclass as state shared by pinned and overlay layouts. Without transition synchronization:- Narrowing while the pinned pane was open carried that open state into overlay mode.
- Closing in overlay mode and then widening carried the closed DOM state back, instead of restoring the saved/default pinned visibility.
The breakpoint listener now detects mode changes, closes when entering overlay without overwriting the pinned visibility cookie, and restores the cookie/default state when returning to a wide pinned layout.
Validation passed:
node --check,git diff --check, andmvn -Pce -pl server-core -am -DskipTests compile. -
Reviewed the current head. The wide-screen collapse controls and persisted pinned visibility behave consistently across pinned and overlay layouts, including viewport transitions; Escape and click-outside closing remain limited to overlay mode.
git diff --checkand JavaScript syntax validation pass. No blocking issues found. -
-
| Submitter | Work Horse |
| Target | main |
| Source | issue-2872-side-info-pane-collapsible |
Allow collapsing the pinned side info pane on wide viewports via the existing More info and close controls. Overlay behavior on narrow screens and hide-side-info layouts is unchanged; click-outside close stays limited to overlay mode.
Fixes #2872