`side-info` pane should be manually collapsible #2872
Zak Siddiqui opened 17 hours ago

The .side-info pane should be manually collapsible.

There are some circumstances where the side info pane is wider than the .issue-activities section.

I've been thinking for a couple of weeks about how to best word an issue so that it can automatically collapse in a more intuitive way for certain screen widths. And I'm sure one day I'll think about it properly, but in the meantime it would be good to be able to manually collapse it.

image.png

  • Work Horse commented 17 hours ago

    Currently the side info pane is only manually collapsible on narrower viewports (max-width: 990px), and on layouts that use hide-side-info (for example some pull request change views).

    On those layouts:

    • Open it with the ⋯ More info control in the header
    • Close it with the close button, Esc, or by clicking outside the pane

    On wider screens the pane stays pinned (360px) and those open/close controls are hidden, so there is no built-in way to collapse it manually today. A temporary workaround is to narrow the browser window below ~990px so the overlay mode is used.

    This request is not something already supported as a setting; it would be an Improvement to allow collapsing the pane on wide screens as well. Escalating to @robin for a product decision (and to retarget the issue type if appropriate).

  • Work Horse changed fields 17 hours ago
    Name Previous Value Current Value
    Assignee
    wh
    robin
  • Zak Siddiqui commented 17 hours ago

    @robin Wow, this is new. I just saw that Workhorse automatically commented.

    Is this because it was automatically added as a watcher? Was there anything further that needs to be done in order to enable this... as in a specific system prompt?

  • Robin Shen commented 17 hours ago

    I write a small groovy script to assign all minor issues and questions to work horse automatically:

    import io.onedev.server.util.EditContext
    
    def type = EditContext.get().getInputValue("Type")
    def priority = EditContext.get().getInputValue("Priority");
    
    if (type == "Question" || type == "Bug" || priority == "Minor")
    	return "wh"
    else
    	return "robin"
    

    Then configure assignee field of the issue to evaluate this script to get the default value. Then in system prompt of work horse tell it to escalate the issues to me in certain cases:

    When you are assigned with an issue of type "Question", try to answer user the question without creating branch or change code. If user is fine with the answer, close the issue then; otherwise, escalate to @robin. Project "onedev/docs" may also be useful when answer questions.
    
  • Robin Shen changed fields 17 hours ago
    Name Previous Value Current Value
    Type
    Question
    Improvement
    Assignee
    robin
    wh
  • Work Horse commented 17 hours ago

    Implemented manual collapse for the side info pane on wide screens in pr #86.

    • ⋯ More info and the pane close button are always available
    • On wide viewports the pane stays pinned when open and collapses in place when closed
    • Esc still closes the pane; click-outside close remains limited to overlay mode (narrow viewports and hide-side-info layouts) so clicking main content does not collapse a pinned pane
1/1
Type
Improvement
Priority
Normal
Assignee
Labels
No labels
Issue Votes (0)
Watchers (3)
Reference
OD-2872
Please wait...
Connection lost or session expired, reload to recover
Page is in error, reload to recover