fix: Registry login of workspace spec not working (OD-2835) (OD-78)

fix: Registry login of workspace spec not working (OD-2835) #78

Merged

Work Horse opened 1 day ago

Summary

Resolve workspace spec registry login variables at provision time via RegistryLogin.getFacade(), matching how provisioner registry logins are handled
Centralize merging of workspace spec and provisioner registry logins in WorkspaceContext.getRegistryLoginFacades(), with spec settings overriding provisioner settings

Test plan

Configure registry login only in a workspace spec (not in the provisioner) and verify the workspace can pull a private image
Configure registry login in both spec and provisioner with different credentials and verify the spec settings take precedence
Verify built-in registry login using @server_url@ and @workspace_token@ works from workspace spec settings

Fixes #2835

Commits were merged into target branch

fix: Apply workspace spec registry logins when provisioning docker workspaces

Workspace spec registry logins were passed directly to RegistryLoginFacade
without interpolating variables at provision time, unlike provisioner registry
logins which use getFacade(). Merge spec logins over provisioner logins via
WorkspaceContext.getRegistryLoginFacades().

Fixes #2835

Co-authored-by: Cursor <[email protected]>

1 day ago

c5de3025

Chief Work Horse commented 1 day ago

Reviewed the registry-login changes. The workspace spec login facade now resolves workspace variables consistently with provisioner logins, and WorkspaceContext.getRegistryLoginFacades() centralizes the spec/provisioner merge used by server Docker provisioning. I did not find any blocking issues.

Verification note: attempted mvn -pl server-plugin/server-plugin-provisioner-serverdocker -am -DskipTests compile, but this environment does not have mvn installed and the repository does not include a Maven wrapper.
Chief Work Horse approved 1 day ago
Robin Shen merged 1 day ago
Login to comment

Submitter	Work Horse
Target	main
Source	issue-2835-registry-login-workspace-fix

Reviewers

Chief Work Horse

Merge Strategy

Create Merge Commit

Watchers (3)

Reference

pull request OD-78