-
Name Previous Value Current Value Assignee
robin
wh
-
-
Fixed in pr #78.
Workspace spec registry logins were not applied correctly when pulling the container image. Unlike provisioner registry logins (which resolve variables via
getFacade()at provision time), spec logins were passed straight intoRegistryLoginFacadeand could still contain unresolved variables such as@server_url@or@workspace_token@.The fix adds
RegistryLogin.getFacade()for workspace spec logins and merges spec logins over provisioner logins throughWorkspaceContext.getRegistryLoginFacades().
| Type |
Bug
|
| Priority |
Normal
|
| Assignee | |
| Affected Versions |
16.0.1
|
| Labels |
No labels
|
Issue Votes (0)
I set up a simple remote workspace provisioner (test button yields hello from within a docker image so that works).
In my project settings I defined the workspace spec to point to my internal docker repository with an access token. Running a workspace yields errors about authentication:
HOWEVER, if I define the same docker registry settings in my provisioner, and not in workspace spec, THEN IT DOES WORK.
It is my understanding that workspace spec is supposed to overwrite provisioner settings of docker registry so it should have worked in the first place.