Add contrast outlines to logo icons #77
Discarded
Chief Work Horse opened 1 day ago

Summary

  • Add white contrast outline to the black OneDev logo PNG
  • Add black contrast outline to the white OneDev logo PNG

Verification

  • Visually inspected both updated PNG assets
  • Unable to run Maven compile because this workspace does not have java, javac, mvn, or a Maven wrapper available on PATH

Fixes OD-2833

This pull request has been discarded
  • Robin Shen commented 1 day ago

    @cah make the border thinner. Also do not touch anything inside the outer border

  • fix: thin logo icon contrast outlines
    Keep the existing logo interiors unchanged and apply the opposite-color outline only around the outer silhouette.
    1 day ago
  • Chief Work Horse commented 1 day ago

    @robin updated the logo assets for review.

    Changes made:

    • reduced the contrast outline from the previous thick border to a 24 px outline on the 700 px PNGs
    • regenerated from the original target-branch assets so existing non-transparent logo pixels are unchanged
    • limited the new outline to the outer silhouette, leaving the interior artwork untouched

    Verification:

    • confirmed original logo pixels have 0 differences against the target-branch versions
    • visually inspected the regenerated PNGs
    • attempted mvn -pl server-core -am -DskipTests compile, but this workspace does not have mvn on PATH
  • Robin Shen commented 1 day ago

    @cah the dark version is completely messed up, please work from original version. This is the mess:

    image.png

  • Chief Work Horse commented 1 day ago

    @robin regenerated the PNG outlines from the original base assets for review.

    Changes made:

    • rebuilt server-core/src/main/java/io/onedev/server/web/img/logo.png and server-core/src/main/java/io/onedev/server/web/img/logo-dark.png from the original PR base versions
    • reduced the contrast outline to 12 px
    • limited new pixels to the exterior perimeter of the outer logo artwork, leaving the original non-transparent pixels unchanged

    Verification:

    • confirmed both regenerated assets have 0 changed original non-transparent pixels, with only new outline pixels added
    • visually inspected checkerboard previews for both assets
    • attempted mvn -pl server-core -am -DskipTests compile, but this workspace does not have mvn on PATH
  • Robin Shen discarded 1 day ago
1/1
Merge Strategy
Create Merge Commit
Watchers (2)
Reference
pull request OD-77
Please wait...
Connection lost or session expired, reload to recover
Page is in error, reload to recover