-
@cah are you able to work on this? The icon in discussion is:
server-core/src/main/java/io/onedev/server/web/img/logo.png
server-core/src/main/java/io/onedev/server/web/img/logo-dark.png
-
Failed to do the job, please open workspace OD-6 for details
-
@cah retry
-
Confirmed the referenced assets are
server-core/src/main/java/io/onedev/server/web/img/logo.pngandserver-core/src/main/java/io/onedev/server/web/img/logo-dark.png. I did not modify them on this checkout per the current instruction. The requested fix is an asset update for those PNGs: add opposite-color contrast outlines to the existing light/dark logo images, or provide bordered variants alongside them if we want to preserve the current unbordered assets. -
Let's just go with simpler approach: add opposite-color contrast outlines to the existing light/dark logo images
-
Name Previous Value Current Value Assignee
robin
cah
-
-
Implemented in pr #77.
Updated
server-core/src/main/java/io/onedev/server/web/img/logo.pngwith a white contrast outline andserver-core/src/main/java/io/onedev/server/web/img/logo-dark.pngwith a black contrast outline. I visually inspected both updated assets.I could not run the required Maven compile command in this workspace because
java,javac,mvn, and a Maven wrapper are not available on PATH.
| Type |
Improvement
|
| Priority |
Normal
|
| Assignee | |
| Labels |
No labels
|
Problem Statement
The current OneDev icon variants suffer from insufficient contrast when rendered against backgrounds that do not match their intended theme. The black icon becomes invisible on dark or dark-colored surfaces, and the white icon becomes invisible on light or light-colored surfaces. This is not limited to the OneDev application itself. It affects any integration point where the icon is embedded externally and the host environment uses a theme outside of our control.
Real-World Impact
Identity portal: We use the OneDev icon as a launch target for users to SSO directly into OneDev. Users choose their own light or dark theme settings on the portal. We cannot enforce a single theme, so we cannot guarantee the icon will be visible.
Browser themes: Users with non-standard browser themes (dark red, dark blue, purple, and similar) find the black icon nearly impossible to see. Switching to the white icon fixes dark theme users but breaks visibility for users on light browser themes.
Temporary workaround: We replaced the icon with the old GitLab icon. The GitLab icon uses a range of contrasting colors, which makes it visible regardless of browser theme. This is not an ideal long-term solution since we are no longer running GitLab.
Proposed Solution
Add a high-contrast border outline to both the black and white icon variants. This way either variant can be rendered on any background color while remaining clearly identifiable.
Visual Description
Imagine the existing OneDev logo shape wrapped in a solid border that is approximately 8 to 12 percent of the icon width:
The border should follow the full outer contour of the logo, including any inner cutouts, so the silhouette is immediately recognizable at small sizes (16px, 24px, and 32px).
Benefits
Suggested Implementation
onedev-black-bordered.svg,onedev-white-bordered.svg)