Move Workspaces dropdown to the sticky side panel (OD-2920)

Move Workspaces dropdown to the sticky side panel #2920

Service Desk opened 4 days ago

Move the Workspaces dropdown from the top operations/status bar into the sticky right-side info panel on issue and pull request pages. Keep the existing dropdown behavior unchanged (open the dropdown to see workspaces; no always-visible status/count on the control).

Context

Raised from discussion on issue #2919. Checking workspaces currently requires scrolling back to the top of long issue/PR pages. The side info panel is sticky, so placing Workspaces there is more convenient.

Originally this issue also called for showing a workspace count on the control. That was dropped: an always-visible status/count would require keeping a live stream of workspace updates and may hurt performance unnecessarily. Relocate the control only.

Out of scope

Do not add an always-visible workspace count/status on the control (see above)
Do not bind workspaces to triggering comments:
1. Workspaces are not necessarily triggered by comments
2. Comment association would clutter the comment list

Acceptance ideas

Workspaces dropdown available in the sticky side info panel (right side)
Dropdown behavior remains as today (open to inspect/create/open workspaces)
Create/open workspace actions remain reachable from that control

Related
- Question about why the workspaces drop down is at the top of issues and pull requests. (OD-2919) Closed

Service Desk referenced from other issue 4 days ago

Question about why the workspaces drop down is at the top of issues and pull requests. (OD-2919)

Closed
Robin Shen commented 4 days ago

This also applies to pull request workspaces

👍 1
Zak Siddiqui commented 3 days ago

Thanks @robin
Zak Siddiqui commented 3 days ago

@robin Just one correction I'd like to make.

I stand corrected on my earlier answer of wanting to always see the status of the workspaces at all times.

I now believe this is the wrong thing to do because it means that we always need to keep a live stream of the latest information from the workspaces.

This may negatively impact performance unnecessarily.

So I think I'd like to keep the workspace's drop-down requirement, meaning move it into the side info panel, but only move it, not change the way it behaves.

CC @servicedesk

PS: The reason for my about-turn is because I read a Medium post about how you take OneDev performance very seriously, and I realized that I do not want to turn OneDev into GitLab bloatware. I want to keep it as a highly performant system.

History

Service Desk changed title 3 days ago

Previous Value	Current Value
Move Workspaces dropdown with count to the sticky side panel	Move Workspaces dropdown to the sticky side panel

Service Desk commented 3 days ago
@zaakiy Thanks for the correction — noted and agreed.

Updated scope for this issue:

Move the existing Workspaces dropdown into the sticky side info panel on issue and pull request pages

Keep current dropdown behavior — no always-visible workspace status or count on the control (that would require a live stream of workspace updates and can hurt performance unnecessarily)

I've updated the issue title and description to match. @robin shout if you want a different direction.
Robin Shen changed fields 2 days ago
Name Previous Value Current Value
Assignee

robin

cwh
Chief Work Horse referenced from pull request 2 days ago

feat: move workspace dropdowns to side panels (OD-100) Merged
Chief Work Horse commented 2 days ago

Implemented the workspace dropdown relocation for issue and pull request pages. The existing dropdown logic and visibility rules are unchanged, and the control now lives in the sticky side info panel.

Verified with mvn -Pce -pl server-core -am -DskipTests compile (BUILD SUCCESS).

Submitted as pr OD-100.
Login to comment

Name	Previous Value	Current Value
Assignee	robin	cwh

Type	Improvement
Priority	Normal
Assignee	Chief Work Horse
Labels	No labels

Issue Votes (0)

Watchers (4)

Reference

OD-2920