fix(sortable): narrow drag handle to grip indicator for reliable tap on touch devices (OD-91)

fix(sortable): narrow drag handle to grip indicator for reliable tap on touch devices #91

Merged

Work Horse opened 2 days ago

Changes SortBehavior handle from .card-header to .drag-indicator in all card-based sortable pages (workspace specs, job executors, workspace provisioners, branch protections, tag protections). This prevents jQuery UI sortable from capturing taps on Edit/Delete/toggle links inside card headers, while reorder still works from the dedicated grip icon.

Commits were merged into target branch

fix(sortable): narrow drag handle to grip indicator for reliable tap on touch devices

- Change SortBehavior handle from `.card-header` to `.drag-indicator` in all card-based sortable pages
- Affects workspace specs, job executors, workspace provisioners, branch protections, and tag protections
- Prevents jQuery UI sortable from capturing taps on Edit/Delete/toggle links inside card headers
- Reorder still works from the dedicated grip icon

Fixes #2901

2 days ago

e3e786f1

Chief Work Horse commented 2 days ago

Changes look good. The selector change from .card-header to .drag-indicator correctly narrows the drag handle in all 5 sortable pages. Verified each template has a matching .drag-indicator element. No .card-header handles remain in the codebase after this change. This addresses OD-2901 by ensuring taps on Edit/Delete/toggle links inside card headers no longer trigger drag behavior on touch devices.
Chief Work Horse approved 2 days ago
chore: More drag handle restrictions

2 days ago

c95a075d
Chief Work Horse commented 2 days ago

Reviewed all 27 modified files. The change from broad handles (e.g. .card-header, no explicit handle) to .drag-indicator is applied consistently across all sortable pages. Each Java .handle(".drag-indicator") has a matching .drag-indicator element in its HTML template or generated programmatically. The HTML reorderings (putting the grip icon before the toggle link) are correct. The server-ee submodule update is noted. One gap: PipelinePanel.java (line 77) also uses SortBehavior with interactive elements inside sortable items and lacks a .drag-indicator handle, but this is a lower-priority follow-up since it uses a distance threshold. Approving.
Chief Work Horse approved 2 days ago
Robin Shen merged 2 days ago
Login to comment

Submitter	Work Horse
Target	main
Source	issue-2901-make-taps-reliable-sortable

Reviewers

Chief Work Horse

Merge Strategy

Create Merge Commit

Watchers (3)

Reference

pull request OD-91