Commits were merged into target branch
-
3 days ago
-
Reviewed the selection-wrapping behavior against the linked issue and existing markdown editor insertion conventions. The change correctly wraps a non-empty selection with backticks, preserves the inner selection, and avoids intercepting modified key combinations. No blocking issues found.
-
-
3 days ago
-
@cwh please review
-
Reviewed the requested selection-wrapping behavior and the caret-position follow-up. Pressing an unmodified backtick with a non-empty selection wraps the selected text, leaves modified shortcuts untouched, moves the caret after the closing delimiter, and emits the editor input event. The JavaScript also passes
node --check; no blocking concerns found. -
-
| Submitter | Work Horse |
| Target | main |
| Source | issue-2879-wrap-selected-text-backticks |
Reviewers
Merge Strategy
Create Merge Commit
Pressing backtick with a text selection in the markdown editor now encloses the selection instead of replacing it.
Fixes #2879