Rootles container (OD-52)
Discarded
This pull request has been discarded
Andreas Wachter opened 2 months ago

this should fix OD-1776

New commits added 2 months ago
Robin Shen commented 2 months ago

Thanks for your help on this. OneDev needs to run as root mostly because it needs to interact with docker daemon to control CI/CD container (kill container, preparing workspace, change workspace owner etc).

Andreas Wachter commented 2 months ago

that makes it a bit difficult. But does it still work with the agents?

Robin Shen commented 2 months ago

Unfortunately agent works the same way.

Andreas Wachter commented 2 months ago

that wasn't what I meant to say. A rootless onedev instance could still communicate with the agents, which are still working as root?

Robin Shen commented 2 months ago

Oh I see. But that is adding complexity and cause confusions. One benefit of OneDev is its out-of-box CI/CD without agents.

Robin Shen discarded 2 months ago
pull request 1 of 1
Assignees
Merge Strategy
Create Merge Commit
Watchers (3)
Reference
pull request OD-52
Please wait...
Page is in error, reload to recover