Plain text notification email contains HTML tags (OD-883)

Plain text notification email contains HTML tags #883

wojtek opened 4 years ago

The email notification I got for https://code.onedev.io/projects/160/issues/871#IssueComment-2424 contains HTML tags in plain-text view:

Robin Shen commented

<div class='no-color'> 
  
  <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> 
  
 
   I was thinking you want to add the marker line in the issue creation email instead of comment reply... 
  <div class="">
   <br class=""> 
  </div> 
  <div class="">
   For comment reply email, OneDev tries its best to automatically trim all quoted contents. It does so by searching for the line containing the system email address specified in mail setting, and remove that line and all contents below that line.&nbsp;
  </div> 
  <div class="">
   <br class=""> 
  </div> 
  <div class="">
   I tested several email clients (Gmail, Outlook, Mac Mail) and this works fine. What is your email client? And what is the content posted at OneDev as comment if you reply the notification email?
  </div></div>

Reply this email to post comment, or visit https://code.onedev.io/projects/160/issues/871#IssueComment-2424 for details

---------------------------------------------
You received this notification as you are participating in this topic. Mail to [email protected] with any content to unsubscribe

It looks ok in HTML view:

Robin Shen commented

I was thinking you want to add the marker line in the issue creation email instead of comment reply...

For comment reply email, OneDev tries its best to automatically trim all quoted contents. It does so by searching for the line containing the system email address specified in mail setting, and remove that line and all contents below that line. 

I tested several email clients (Gmail, Outlook, Mac Mail) and this works fine. What is your email client? And what is the content posted at OneDev as comment if you reply the notification email?

Reply this email to post comment, or click this link for details
You received this as you are participating in this topic. Mail to this address to unsubscribe

Captura de Pantalla 2022-08-21 a las 11.46.18.png

Copy

Robin Shen commented 4 years ago

Let me know your email client, as well as how you are viewing the plain text content.

Copy
wojtek commented 4 years ago

I'm using Thunderbird 102.1.2 (64-bit). I configured it that way: View -> Message body as -> Plain text.

Copy
OneDev changed state to 'Closed' 4 years ago
Previous Value Current Value
Open

Closed
OneDev commented 4 years ago

State changed as code fixing the issue is committed

Copy
OneDev changed state to 'Released' 4 years ago
Previous Value Current Value
Closed

Released
OneDev commented 4 years ago

State changed as build #2909 is successful

Copy
wojtek changed state to 'Open' 3 years ago
Previous Value Current Value
Released

Open
wojtek commented 3 years ago

Once again (plain portion of) email notification started to contain HTML tags and odd formatting. Ideally quoted text should use regular > symbol and all html tags should be stripped:

Copy
Robin Shen changed state to 'Closed' 3 years ago
Previous Value Current Value
Open

Closed
Robin Shen commented 3 years ago

This happens as this site (onedev.io) is using an obsolete notification template, and it has now been fixed by resetting to default template.

PS: all email notifications can now be customized via administration / email templates. If this issue also happens at your side, make sure to revert to default template whic contains logic to use different template for html and plain text version.

Copy
Login to comment

Previous Value	Current Value
Open	Closed

Previous Value	Current Value
Closed	Released

Previous Value	Current Value
Released	Open

Previous Value	Current Value
Open	Closed

Type	Bug
Priority	Normal
Assignee	Robin Shen

Issue Votes (1)

Watchers (4)

Reference

OD-883