Add environment variable configuration options (OD-63)
Phil's Lab opened 6 years ago

For the sake of easy deployment via docker/kubernetes, you should consider adding support for environment variable configuration.

I'm thinking about those options primarily:

  • External database
  • Web URL
  • Email settings
  • Enable/Disable SSH access
  • Robin Shen commented 6 years ago

    You may set environment variable in your job script directly as necessary, for instance:

    external_database = @params:external_database@
    email_settings="some hard coded settings"
    ...
    

    This requires fewer configuration and is much flexible to my opinion

  • Phil's Lab commented 6 years ago

    I think you misunderstood. I'm talking about the server itself, not the job scripts.

  • Robin Shen commented 6 years ago

    Specifying external database via environment variables is currently supported. Check k8s resources for details.

    Specifying SSH via environment variables will also be available once SSH support is added.

    However I'd like not to add other settings such as email which can be configured via GUI, as otherwise we may need to duplicate many GUI settings from environment variables, which will complicate things a lot. For those settings, I'd suggest to build a custom onedev image for your own purpose.

  • Robin Shen commented 6 years ago

    Also settings done via GUI may gets upgraded automatically as OneDev upgrades. Doing it via environment variables increased difficulty of maintenance.

  • Robin Shen batch edited 6 years ago
    Name Previous Value Current Value
    Iterations
    empty
    3.2.0
  • Robin Shen batch edited 6 years ago
    Name Previous Value Current Value
    Iterations
    3.2.0
    3.3.0
  • Robin Shen batch edited 6 years ago
    Name Previous Value Current Value
    Iterations
    3.3.0
    3.2.0
  • Robin Shen changed state to 'Closed' 6 years ago
    Previous Value Current Value
    Open
    Closed
issue 1/1
Type
New Feature
Priority
Normal
Assignee
Iterations
Issue Votes (0)
Watchers (2)
Reference
OD-63
Please wait...
Connection lost or session expired, reload to recover
Page is in error, reload to recover