Error using agent to get system information (OD-524)

deadash opened 4 years ago

the error is as follows

Launching a JVM...
WrapperManager: Initializing...
11:14:38 INFO  io.onedev.agent.Agent - Cleaning temp directory...
11:14:38 INFO  io.onedev.agent.ExecutorUtils - Checking Windows OS version...
11:14:45 ERROR io.onedev.agent.Agent - Error running agent
io.onedev.commons.utils.ExplicitException: Unable to find Windows OS version
        at io.onedev.agent.ExecutorUtils.getOsInfo(ExecutorUtils.java:74)
        at io.onedev.agent.Agent.main(Agent.java:202)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:568)
        at org.tanukisoftware.wrapper.WrapperSimpleApp.run(WrapperSimpleApp.java:349)
        at java.base/java.lang.Thread.run(Thread.java:833)
11:15:45 INFO  io.onedev.agent.Agent - Waiting for running jobs to finish...
<-- Wrapper Stopped

View the relevant code as follows

https://code.onedev.io/projects/235/blob/525ca84e1da5e8750f2ed92234cb00e65597af31/src/main/java/io/onedev/agent/ExecutorUtils.java?position=source-65.46-65.56-1

My system is a non-English system, so it is definitely wrong to get it this way.

should be replaced with the following command

systeminfo.exe /FOcsv /NH

Then divide the processing in order.

Robin Shen commented 4 years ago

Thanks for reporting the bug.
OneDev changed state to 'Closed' 4 years ago
Previous Value Current Value
Open

Closed
OneDev commented 4 years ago

State changed as code fixing the issue is committed
OneDev changed state to 'Released' 4 years ago
Previous Value Current Value
Closed

Released
OneDev commented 4 years ago

State changed as build #2222 is successful
Login to comment

Previous Value	Current Value
Open	Closed

Previous Value	Current Value
Closed	Released

Type	Bug
Priority	Critical
Assignee	Robin Shen
Affected Versions	Not Found

Issue Votes (0)

Watchers (3)

Reference

OD-524