Image are required with shell-executor steps too (OD-468)

Closed

Activities

Stephen S opened 2 years ago

I have created a shell Job executor
in the .onedev-buildspec.yml file, I force the use of this shell Job Executor
I create a new step and omit to declare an Image, as stated in the smallprint below the Image field
and yet OneDev demands an image:

What am I doing wrong?

Robin Shen commented 2 years ago

For shell executor, just fill an arbitrary value for it as it will not be used. This is required as the step does not know whether or not it will be executed by a docker executor, or a shell executor as executor can be determined at runtime. Further, a step can be defined as a template in which case it is also impossible to know which executor will run the job.

Stephen S commented 2 years ago

Thanks Robin, that makes sense.

OneDev referenced from other issue 2 years ago

How do you close an issue you have opened? (OD-470)

Closed

Robin Shen changed state to 'Closed' 2 years ago

Previous Value	Current Value
Open	Closed

Type	Bug
Priority	Minor
Assignee	Robin Shen
Affected Versions	Not Found

Issue Votes (0)

Watchers (3)

Reference

OD-468