Keep file tree at full window height in revision diff view to avoid layout jumping #3264
Robin Shen opened 9 hours ago

Follow-up enhancement requested in a comment by jbauer on OD-3246 (Show one file at a time in revision diffs):

Currently, when switching between files with a short diff and a long diff, the UI jumps up and down depending on the height of the diff viewer. It would be nice if the file tree kept the full window height so that the page layout stays stable while navigating between files.

Note from the reporter: their attempt at setting height: 100vh did not play well with the current div structure, so the layout may need to be restructured (e.g. flex layout with an independently scrolling diff pane) to achieve this.

Acceptance criteria:

  • The file tree occupies the full height of the viewport (or the available content area) regardless of the selected file's diff length.
  • Switching between short and long diffs via the tree, Previous/Next, or links does not cause the overall page layout to jump.
  • Scrolling of long diffs happens within the diff pane without changing the position/height of the file tree.

Original issue: https://code.onedev.io/onedev/server/~issues/3246

1/1
Type
Enhancement
Priority
Normal
Assignee
Labels
No labels
Issue Votes (0)
Watchers (1)
Reference
OD-3264
Please wait...
Connection lost or session expired, reload to recover
Page is in error, reload to recover