In the pull request overview, it is difficult to distinguish a pending review from a review requesting changes at a glance. Both status icons use the same warning color, and the reviewer-avatar status icons are only 10 x 10 pixels. This is especially noticeable when scanning multiple PRs, including PRs being reviewed by an AI user: one needs to distinguish waiting for a review result from a result requiring action.
Steps to reproduce
Open a pull request list containing PRs with pending reviews and PRs with requested changes.
Compare the small review status icons on reviewer avatars.
Both states have the same color; distinguishing them relies on recognizing the small clock/diff glyph or opening a tooltip.
Expected behavior
Use distinct semantic colors, while retaining different icon shapes and tooltips:
Approved: green (as today).
Pending review: blue / informational.
Requested changes: red / action required.
An ongoing AI task is a separate state; the core issue here is that pending review and requested changes share a color. Making these colors distinct would improve scanning even without changing icon sizes or adding settings.
Source reference
In server-core/src/main/java/io/onedev/server/web/component/pullrequest/review/review.css, both .review-status-pending.icon and .review-status-request-for-changes.icon currently use fill: var(--warning). The same file sets reviewer-avatar status icons to 10px.
OneDev version: 16.8.4
In the pull request overview, it is difficult to distinguish a pending review from a review requesting changes at a glance. Both status icons use the same warning color, and the reviewer-avatar status icons are only 10 x 10 pixels. This is especially noticeable when scanning multiple PRs, including PRs being reviewed by an AI user: one needs to distinguish waiting for a review result from a result requiring action.
Steps to reproduce
Expected behavior
Use distinct semantic colors, while retaining different icon shapes and tooltips:
An ongoing AI task is a separate state; the core issue here is that pending review and requested changes share a color. Making these colors distinct would improve scanning even without changing icon sizes or adding settings.
Source reference
In
server-core/src/main/java/io/onedev/server/web/component/pullrequest/review/review.css, both.review-status-pending.iconand.review-status-request-for-changes.iconcurrently usefill: var(--warning). The same file sets reviewer-avatar status icons to 10px.https://github.com/theonedev/onedev/blob/v16.8.4/server-core/src/main/java/io/onedev/server/web/component/pullrequest/review/review.css
Please also check the resulting colors in both light and dark themes. Keeping the distinct glyphs/tooltips avoids relying on color alone.