Improve pull request suggested title and description for conventional commits #3063
jbauer opened 3 weeks ago

I am not sure if it is regression or not but I just did a PR with a single commit and the commit message was fix(sql): example text.

Creating a PR suggested a PR title fix: fix(sql): example text and the PR description showed fix(sql): example text.

However I would expect a suggested PR title fix(sql): example text and an empty description (because the commit only had a title in terms of conventional commits. No description and no footer).

  • Robin Shen commented 3 weeks ago

    Works at my side, please describe detail steps to reproduce.

  • Robin Shen changed state to 'Closed' 2 weeks ago
    Previous Value Current Value
    Open
    Closed
  • jbauer commented 2 days ago

    @robin I had vacation. Still happens in 16.5.12, haven't updated to latest yet. I tried to fork the server project here to try it here but it seems users cannot create projects here anymore? I tried "forks", "forks/jbauer" as parent project but both did not work (not authorized). Also I would have expected that a default fork location is provided but the box was empty.

    As the commit message was german, can you try something with german umlauts like a single commit fix(sql): SQL-Korrekturdateien müssen übersprungen werden and then create a PR with that commit? Also it looks like that the description is filled via AI as I can briefly see "Suggesting .." and then the german commit message is repeated in english as PR description.

    My gut feeling says it might be some regex issue with regard to unicode so that only english ascii is currently checked. We had that before with some other issue.

  • Robin Shen changed state to 'Open' 1 day ago
    Previous Value Current Value
    Closed
    Open
1/1
Type
Bug
Priority
Normal
Assignee
Affected Versions
16.5.8
Labels
No labels
Issue Votes (0)
Watchers (2)
Reference
OD-3063
Please wait...
Connection lost or session expired, reload to recover
Page is in error, reload to recover