Environment

• OneDev version: 15.0.8
• Git operation: Push a tag to OneDev
• Affected tag example: 1.0.10+16
• Branch pushes work normally

Description

Pushing a Git tag whose name contains a + character fails during the server-side pre-receive hook.

For example:

git tag 1.0.10+16
git push origin 1.0.10+16

The client receives:

remote: curl: (22) The requested URL returned error: 500
! [remote rejected] 1.0.10+16 -> 1.0.10+16 (pre-receive hook declined)
error: failed to push some refs

The tag remains local and is not created on the remote repository.

Normal branch pushes to the same repository/server work correctly.

Server-side exception

At the same time, OneDev logs the following exception:

ERROR i.o.s.security.ExceptionHandleFilter - Error processing servlet request

org.eclipse.jgit.errors.InvalidObjectIdException: Invalid id: refs/tags/1.0.10

    at org.eclipse.jgit.lib.ObjectId.fromString(ObjectId.java:203)
    at io.onedev.server.git.hook.GitPreReceiveCallback.doPost(GitPreReceiveCallback.java:119)
    at io.onedev.server.persistence.SessionInterceptor$1.call(SessionInterceptor.java:23)
    at io.onedev.server.persistence.DefaultSessionService.call(DefaultSessionService.java:85)
    at io.onedev.server.persistence.SessionInterceptor.invoke(SessionInterceptor.java:18)
    ...

The interesting part is:

Invalid id: refs/tags/1.0.10

The original tag being pushed is:

refs/tags/1.0.10+16

but the exception only contains:

refs/tags/1.0.10

Steps to reproduce

1. Create a repository in OneDev 15.0.8.
2. Clone the repository.
3. Create a commit if necessary.
4. Create a tag containing +:

git tag 1.0.10+16

5. Push the tag:

git push origin 1.0.10+16

Actual result

The push is rejected:

remote: curl: (22) The requested URL returned error: 500
! [remote rejected] 1.0.10+16 -> 1.0.10+16 (pre-receive hook declined)

OneDev logs:

org.eclipse.jgit.errors.InvalidObjectIdException:
Invalid id: refs/tags/1.0.10

from:

io.onedev.server.git.hook.GitPreReceiveCallback.doPost(...)

Expected result

+ is a valid character in a Git ref/tag name.

The following tag should therefore be accepted normally:

refs/tags/1.0.10+16

and the tag should be created on the remote repository.

Suspected cause

This appears to be related to URL/form decoding in the pre-receive hook callback.

The original ref update contains:

refs/tags/1.0.10+16

If the hook sends the ref-update data as application/x-www-form-urlencoded without encoding the literal +, a servlet/form decoder may interpret + as a space:

refs/tags/1.0.10+16

becoming:

refs/tags/1.0.10 16

If OneDev then parses the ref-update record by whitespace, the fields become shifted.

That would explain why:

refs/tags/1.0.10

is eventually passed to:

ObjectId.fromString(...)

and results in:

InvalidObjectIdException: Invalid id: refs/tags/1.0.10

This is only a suspected root cause, but the server-side exception appears consistent with the + character being decoded as whitespace before GitPreReceiveCallback parses the ref update.

Related observations

• Branch pushes to the same OneDev server work normally.
• The failure occurs in the server-side GitPreReceiveCallback.
• The HTTP 500 is generated by the OneDev callback; it is not a Git authentication or refspec error.
• The pushed tag is valid according to Git ref naming rules.
• The original ref contains +16, while the exception shows refs/tags/1.0.10, suggesting the + affects parsing before the object ID conversion.

Related issues checked

I checked several existing tag/push-related issues, but they appear to have different root causes:

• OD-1297 — Pushing tags in CI/CD
• OD-1409 — Similar client-side curl (22) / pre-receive hook declined symptom, but related to repository/filesystem ownership
• OD-1585 — Annotated tag handling/fetch issue
• OD-2359 — Server-side error after pushing a tag related to scheduled builds
• OD-2729 — Git repository ownership / safe.directory issue

I could not find an existing issue specifically describing a tag/ref containing + causing GitPreReceiveCallback to parse the ref incorrectly.