No fixed reviewers on pull requests #2995
Dominik opened 20 hours ago

Is it currently possible to maker reviewers not fixed but allow just anyone from the reviewer group to review and merge a pull request instead of having a fixed person assigned at all times? Its kinda annoying since the picked reviewers get sent mails for pull requests even when someone else is currently available that could just review a pull request.

  • Dominik changed title 20 hours ago
    Previous Value Current Value
    Issues fixed reviewers
    No fixed reviewers on pull request
  • Dominik changed title 20 hours ago
    Previous Value Current Value
    No fixed reviewers on pull request
    No fixed reviewers on pull requests
  • Service Desk commented 20 hours ago

    Yes — you can require approvals from a group instead of naming fixed individual reviewers.

    Setup

    In the target project's branch protection settings, set the review requirement to a group, for example:

    • group(Reviewers) — one approval from any member of that group
    • group(Reviewers):2 — two approvals from that group

    See also:

    Behavior

    When the requirement uses a group, OneDev auto-suggests the most appropriate members (based on commit history of the touched files) and assigns them as reviewers. Those assignees are notified by mail.

    They are not permanently fixed:

    • If the suggested person is unavailable, remove them on the pull request — OneDev will pick another suitable member from the group.
    • You can also add other reviewers manually.

    Limitation

    There is no mode that leaves a pull request with no assigned reviewers while still enforcing “anyone from the group may approve.” Approvals are always tied to assigned reviewers; for group rules, the set of assignees is flexible and can be swapped as above.

    If that still does not cover your workflow (e.g. you want zero auto-assignment / no mail until someone claims the review), please say so and we can treat it as a feature request.

  • Dominik commented 20 hours ago

    Sadly this does not cover my workflow. I would like to have the pull requests open for taking when freshly created and anyone from that group can review them in addition to manually added reviewers that are then still needed for the pr to be merged.

  • Dominik changed fields 20 hours ago
    Name Previous Value Current Value
    Type
    Question
    New Feature
  • Service Desk commented 20 hours ago

    Thanks for clarifying. That workflow is not supported today:

    1. With a group review requirement, OneDev always auto-assigns suggested members (and notifies them). There is no “open for taking” mode that leaves a newly created PR with no reviewers until someone claims it.
    2. Approvals that satisfy the group rule come from assigned reviewers. Other group members can review only after they are added as reviewers.
    3. Manually added reviewers already must approve before merge (all non-excluded reviewers must approve).

    So the gap is: keep group (and optional individual) review requirements, but skip auto-assignment so the PR stays claimable by any group member, while still requiring any manually added reviewers.

    @robin — escalating as a feature request for optional “no auto-assign / claimable review” behavior on group review requirements.

  • Service Desk changed fields 20 hours ago
    Name Previous Value Current Value
    Assignee
    servicedesk
    robin
  • Robin Shen commented 13 hours ago

    This seems odd to me, as no one will be notified of such PR and no one will be actually responsible for it...

1/1
Type
New Feature
Priority
Normal
Assignee
Labels
No labels
Issue Votes (0)
Watchers (3)
Reference
OD-2995
Please wait...
Connection lost or session expired, reload to recover
Page is in error, reload to recover