-
OneDev needs to mark unverified email, as not doing so can impose security issues:
- User adds an unverified email of other staff (email not currently used in OneDev)
- User configures local git to use that email for commit authoring
- User configures PGP signing of the commit
- When the commit is pushed to OneDev, the commit is displayed as signed commit using that email to get trust.
-
State changed as build OD-8064 is successful
-
OneDev
changed state to 'Closed' 2 weeks ago
Previous Value Current Value Open
Closed
-
Previous Value Current Value Default private email
Default private email for git operations
-
Thinking about why gitea and github private email contain a number before the email address, I think it is the user ID (for example github ID can be check with the API: https://api.github.com/users/zarpyk and is the same number, on gitea I think I'm just the user number 1), so if you change the login name, other people can't get you noreply email.
With the current implementation, if you change your login name, the noreply email become available for anyone that get your old login name? I don't know how GPG key works exactly.
-
OneDev intentionally does not prepend user id as that can lead to all git commits incorrectly associating with incorrect user if you import the repository into another OneDev instance (or other git hosting software such as Gitea) which may use different user id for same login.
Changing login name can be a problem, and we should avoid changing login name in normal cases. I think this is a common limitation for many systems.
| Type |
New Feature
|
| Priority |
Major
|
| Assignee | |
| Labels |
No labels
|
With admin account I think you can put directly unverified email like [email protected], but as user it require verified email to set it as Git email.
Github and Gitea allow user to set private emails as emails to commit (Gitea also allow set this option to true by default for all users)
Gitea:
Github: