-
Previous Value Current Value No date in check-data-version.log
No date in backup-db.log, check-data-version.log, restore-db.log
-
Name Previous Value Current Value Priority
Normal
Minor
-
Hi, I'd like to contribute a fix for this issue (patch attached).
Root cause: for command runs (backup-db, restore-db, check-data-version, ...),
Bootstrap.configureLogging()in commons-bootstrap sets the file log pattern to%-5level - %msg%n, which lacks%date- while server mode uses%date %-5level [%thread] %logger{36} %msg%n. Hence command log files have no dates.Fix: add a static helper in
CommandHandlerthat prepends%dateto the FILE appender's pattern. It is a no-op in server mode (Bootstrap.command == nullguard) and idempotent (skips if the pattern already contains%d, so it won't double-prepend if commons is fixed upstream later). It is called from theCommandHandlerconstructor (covers backup-db, restore-db, check-data-version, clean-db, reset-admin-password, apply-db-constraints, translate) and from a newUpgradeconstructor, sinceUpgradeextendsAbstractPlugindirectly (covers upgrade.log). Console output is left unchanged.Verified with a minimal repro replaying the command-mode logging config: before -
INFO - ...; after -2026-07-10 13:42:29,714 INFO - ....I tried forking this project to raise a proper PR, but my account is not authorized to create projects. Happy to submit a PR instead if fork permission can be granted.od-2805-fix.patch
-
@xavier-github76 thanks for sending the patch. Nevertheless, the cleanest fix is to modify Bootstrap directly. I've done that and will get it into next patch release. Also added your account to Contributor group and you will be able to submit PR in future.
-
@robin Hi Robin,
Thanks for implementing the cleaner fix in Bootstrap!
Just a quick heads-up: I think you might have accidentally added the issue author (@xavier-github76) to the Contributor group instead of me. My GitHub account is @wds3817.
Could you please add my account when you get a chance? Thank you!
Best regards, Roy
-
| Type |
Improvement
|
| Priority |
Minor
|
| Assignee | |
| Labels |
No labels
|
Logs don't have date in :
backup-db.log
check-data-version.log
restore-db.log
Date is present only in console.log and server.log