Binding to a specific IP address breaks pushing, because localhost is used with curl (OD-2682)

Binding to a specific IP address breaks pushing, because localhost is used with curl #2682

Johan Stuyts opened 5 months ago

If I set http_host in server.properties to a specific IP address instead of 0.0.0.0, pushing is broken. The error is that curl cannot connect to port 6610 on localhost.

I checked the code to see if it was possible to specify multiple bind addresses, but this does not seem to be possible.

In HookUtils#getHookEnvs the configured HTTP port is used to configure the URL, but the host name is hardcoded to localhost. localhost should only be used if http_host equals 0.0.0.0. Otherwise, the configured IP address should be used.

Robin Shen commented 5 months ago

Thanks for reporting the issue. Will bind to 127.0.0.1 in addition to ip address specified in server.properties, as curl sends senstive info and it is only safe for localhost access.

History 👍 1
Davide Beatrici commented 5 months ago

Let's bind to ::1 too.
Robin Shen commented 5 months ago

Let's bind to ::1 too.

Will do
OneDev commented 5 months ago

State changed as build OD-7079 is successful
OneDev changed state to 'Closed' 5 months ago
Previous Value Current Value
Open

Closed
Login to comment

Previous Value	Current Value
Open	Closed

Type	Bug
Priority	Minor
Assignee	Robin Shen
Affected Versions	14.0.8
Labels	No labels

Issue Votes (0)

Watchers (5)

Reference

OD-2682