PullRepository step fails due to anonymous principal causing null to be returned by SecurityUtils#getUser (OD-2569)

Jordan Adams opened 4 months ago

This commit seems to make an assumption that SecurityUtils#getUser will return a User but it does not always do so, in the PullRepository step, the principal can return anonymous which causes an NPE when trying to call User#getId

Edit: Sorry about the changes after the submission, it appears as though I had 2 new issue tabs open, one was properly set to Bug, the other had the default fields

Jordan Adams changed fields 4 months ago
Name Previous Value Current Value
Type

Question

Bug

Affected Versions
empty
>13.0.0
Jordan Adams changed fields 4 months ago
Name Previous Value Current Value
Affected Versions

>13.0.0

>=13.0.0
OneDev commented 4 months ago

State changed as code fixing the issue is committed (a32ff3f7)
OneDev changed state to 'Closed' 4 months ago
Previous Value Current Value
Open

Closed
OneDev commented 4 months ago

State changed as build OD-6685 is successful
OneDev changed state to 'Released' 4 months ago
Previous Value Current Value
Closed

Released
Login to comment

Name	Previous Value	Current Value
Type	Question	Bug
Affected Versions	empty	>13.0.0

Name	Previous Value	Current Value
Affected Versions	>13.0.0	>=13.0.0

Previous Value	Current Value
Open	Closed

Previous Value	Current Value
Closed	Released

Type	Bug
Priority	Normal
Assignee	Robin Shen
Affected Versions	>=13.0.0
Labels	No labels

Issue Votes (0)

Watchers (3)

Reference

OD-2569