Update Project Settings API endpoint does not have same validation as frontend, leading to NPE (OD-2568)

Update Project Settings API endpoint does not have same validation as frontend, leading to NPE (OD-2568)

Jordan Adams opened 4 months ago

Through the API you can update the project settings, and you can add a secret with an empty value, this appears to be coerced to null which causes an NullPointerException

DefaultJobManager#run:1259
- DefaultJobManager#execute:638
  - Build#getSecretMasker:915
    - Build#getMaskSecrets#933
      - s is null in the case of a empty value in the secret which causes the String#length call to cause an NPE

OneDev commented 4 months ago

State changed as code fixing the issue is committed (6b597c6c)
OneDev changed state to 'Closed' 4 months ago
Previous Value Current Value
Open

Closed
OneDev commented 4 months ago

State changed as build OD-6685 is successful
OneDev changed state to 'Released' 4 months ago
Previous Value Current Value
Closed

Released
Login to comment

Type	Bug
Priority	Minor
Assignee	Robin Shen
Affected Versions	13.0.4
Labels	No labels

Issue Votes (0)

Watchers (3)

Reference

OD-2568

Please wait...

Connection lost or session expired, reload to recover

Page is in error, reload to recover