Cache cannot tar files with '..' in filename (OD-2404)

Dennis Becker opened 8 months ago

I have created a cache for the node_modules folder following the instructions in the docs. Now I have a problem that a file within the node_modules directory has '..' in its filename so the cache does not work. I have updated onedev and onedev-agent docker images to latest versions today. I get the following log output:

10:35:02 Step "Checkout" is successful (7 seconds)
10:35:02 Running step "generate package checksum"...
10:35:03 20.04: Pulling from library/ubuntu
10:35:03 Digest: sha256:8feb4d8ca5354def3d8fce243717141ce31e2c428701f6682bd2fafe15388214
10:35:03 Status: Image is up to date for ubuntu:20.04
10:35:04 Generated checksum: 477a66761751670818563120b4f95622
10:35:05 Step "generate package checksum" is successful (2 seconds)
10:35:05 Running step "set up npm cache"...
10:35:09 Tar entry name contains '..': netlify-cli/node_modules/@fastify/send/test/fixtures/do..ts.txt

Is there a way to exclude subfolders? I don't know why fastify pushes their tests in a npm package and will talk to them as well.

Robin Shen changed fields 8 months ago
Name Previous Value Current Value
Type

Question

Bug

Affected Versions
empty
<=11.9.3
OneDev commented 8 months ago

State changed as code fixing the issue is committed (6662d064)
OneDev changed state to 'Closed' 8 months ago
Previous Value Current Value
Open

Closed
OneDev commented 8 months ago

State changed as build OD-6174 is successful
OneDev changed state to 'Released' 8 months ago
Previous Value Current Value
Closed

Released
Robin Shen referenced from other issue 6 months ago

caching directory with file containing `..` in name (OD-2495)

Closed
Login to comment

Name	Previous Value	Current Value
Type	Question	Bug
Affected Versions	empty	<=11.9.3

Previous Value	Current Value
Open	Closed

Previous Value	Current Value
Closed	Released

Type	Bug
Priority	Minor
Assignee	Robin Shen
Affected Versions	<=11.9.3
Labels	No labels

Issue Votes (0)

Watchers (3)

Reference

OD-2404