Automatic selection of light/dark mode (`prefers-color-scheme`) (OD-2276)

Automatic selection of light/dark mode (`prefers-color-scheme`) #2276

wojtek opened 2 years ago

Would it be possible to switch to light/dark mode based on system setting (i.e. utilizing prefers-color-scheme)? Quite a lot of websites follow this pattern and it makes using the service in the evening easier.

Ref: https://css-tricks.com/a-complete-guide-to-dark-mode-on-the-web/#os-level

Copy

Ole H commented 3 weeks ago

@robin can I work on this one?

Copy
Robin Shen commented 3 weeks ago

yes please

Copy
Ole H commented 3 weeks ago

Hi @robin

Before I get started, I'm hitting a build issue on a fresh clone of main: running ./dev.sh run (or mvn package -Pce) fails because server-product can't resolve io.onedev:server-ee:jar:16.5.9 from any configured repository (onedev, jetbrains, jenkins, central).

Is this expected for external contributors, or is there a specific tag/branch I should build against instead of main to get a version with a published server-ee artifact? Happy to share the full log if that helps.

Copy
Robin Shen commented 3 weeks ago

@crayson09 please pull and run ./dev.sh build first.

Copy
Ole H commented 3 weeks ago

Hey @robin , I'm done on my end. How should I proceed from here? I can't seem to fork the repo or add an SSH key on this OneDev instance.

Copy
Robin Shen commented 3 weeks ago

@crayson09 Added your account to contributor and you may now fork the repository from project overview page.

Copy
Ole H commented 3 weeks ago

@robin fork worked, but I still cant add an ssh key or I cant find the option to do it

Copy
Robin Shen commented 3 weeks ago

@crayson09 SSH access to this instance is disabled, please pull/push via http.

Copy 👍 1
Ole H commented 2 weeks ago

@robin you need to close the issue

Copy
Robin Shen commented 2 weeks ago

@crayson09 this will be closed automatically when next release is available.

Copy 👍 1
OneDev commented 2 weeks ago

State changed as build OD-8348 is successful

Copy
OneDev changed state to 'Closed' 2 weeks ago
Previous Value Current Value
Open

Closed
Login to comment

Previous Value	Current Value
Open	Closed

Type	Improvement
Priority	Normal
Assignee	Robin Shen
Labels	No labels

Issue Votes (0)

Watchers (2)

Reference

OD-2276