Exception when set reviewed state for same file in same pull request by different user (OD-2228)

alion opened 1 year ago

Hi ,

I found a problem, My pull request was merged, and In the Files changes tab, the review button display 'Set reviewed' , but switch to the pull request reviewer account, and come to above page, the review button display 'set unreviewed'

How reproduce:

Precondition: two account, a1(pr submitter), a2(pr reviewer), merge strategy: rebase

a1 create a pull request, set reviewer to a2
login a2 account, and go to pull request's File Changes tab, then click the set reviewed button, finally click approve
login a1 account and view the review state, you will found 'set reviewed' , it's wrong, when click it the error occurs
login a2 account and view the review state, you will found 'set unreviewed', it's right.

Robin Shen changed title 1 year ago

Previous Value	Current Value
Same pull request and one reviewed state, but different display reviewed result for reviewer and submitter	Exception when set reviewed state for same file in same pull request by different user

OneDev changed state to 'Closed' 1 year ago
Previous Value Current Value
Open

Closed
OneDev commented 1 year ago

State changed as code fixing the issue is committed (c211d811)
OneDev changed state to 'Released' 1 year ago
Previous Value Current Value
Closed

Released
OneDev commented 1 year ago

State changed as build OD-5810 is successful
alion commented 1 year ago

Hi @robin

Thank you for fixing this bug. However, I noticed that it only resolves the issue of the error when clicking the review button.

The reviewer is shown as “Reviewed,” while the submitter is shown as “Not Reviewed.” I believe this is also a bug, isn’t it?
Robin Shen commented 1 year ago

This is expected behavior, as review status is per user. a1 reviewed a file does not mean a2 also reviewed the file.
alion commented 1 year ago

Alright 👌
empinator referenced from other issue 12 months ago

Pull Request - Scroll to reviewed file link (OD-2249)

Released
Login to comment

Previous Value	Current Value
Open	Closed

Previous Value	Current Value
Closed	Released

Type	Bug
Priority	Normal
Assignee	Robin Shen
Affected Versions	11.6.7
Labels	No labels

Issue Votes (0)

Watchers (2)

Reference

OD-2228