Job Variable autocomplete not working (OD-221)
Michael Weimann opened 5 years ago

Reproduction steps

  • Open a build spec
  • Click on edit
  • Type an @ into the command text box

Expected behaviour:

  • List of variables as mentioned in the description

Actual behaviour:

  • Nothing happens

I have tested this on the 4.0.8 deployment here.

Browsers:

  • Chromium 87.0.4280.88
  • Firefox 84.0
  • Michael Weimann changed fields 5 years ago
    Name Previous Value Current Value
    Seen Builds
    1075
    1071
  • Robin Shen commented 5 years ago

    I tested with this instance and also 4.0.8 docker mode with Chrome, and variable prompting is working. Anything special at your side?

  • Michael Weimann commented 5 years ago

    I have tested it with Firefox 84 and Chromium 87. Neither did work.
    There are no JavaScript console errors and there is no Ajax request when typing @ into the editor field.

    If you have any other ideas how to debug this please let me know.

    It does not work on another OneDev instance using 4.0.7.

  • Unknown commented 5 years ago

    Please follow below steps to check if it works:

    1. Login to code.onedev.io
    2. Create a new project
    3. Add file .onedev-buildspec.yml from web UI
    4. Input @ in commands field
  • Michael Weimann commented 5 years ago

    Please follow below steps to check if it works...

    Well that is what I described in the issue description, isn't it? ;)

    Also tested that with a brand new project; same issue here.

  • Robin Shen commented 5 years ago

    This is odd. I tested fine with different browsers and OS. Can you please help to debug this issue?

    To debug it, please set up your dev environment following this: https://code.onedev.io/projects/onedev-manual/blob/4.0/pages/development-environment-setup.md

    Then in browser, find file code-support.js and put a break point at line 26. Then input '@' to see why it is not being handled.

  • Robin Shen commented 5 years ago

    @mweimann any chance to look into source why this is not working at your side?

  • Michael Weimann commented 5 years ago

    @robin thanks for asking. I may have some spare time at the week end and will check it then.

  • Michael Weimann commented 5 years ago

    Found it: On my keyboard (DE layout) the @ sign does not have keyCode 50. Switching to key should solve this even for other layouts.

    pull request #22

  • OneDev changed state to 'Closed' 5 years ago
    Previous Value Current Value
    Open
    Closed
  • OneDev changed state to 'Released' 5 years ago
    Previous Value Current Value
    Closed
    Released
issue 1/1
Type
Bug
Priority
Normal
Assignee
Affected Versions
Not Found
Issue Votes (0)
Watchers (3)
Reference
OD-221
Please wait...
Connection lost or session expired, reload to recover
Page is in error, reload to recover