Code Review: File explorer does not show all files if many files in PR (OD-2187)
jbauer opened 1 year ago

The recent change introducing a file explorer in a PR code review is great but because all files of the PR are rendered OneDev still limits the amount of files in combination with the file lengths. Once that limit is active the file explorer also only shows the files that have been rendered, e.g. only 10 out of 40 files.

This behavior is unintuitive because a file explorer is expected to show all files of the PR. As there is no option anymore to show files one by one you are again forced to use the search box to navigate folders/packages to see the files that OneDev did not show initially. That undermines the usefulness of the file explorer.

Proposal:

Always use one-by-one rendering because OneDev now has a file explorer which lets you easily switch between files. The file explorer could then show all files affected in the PR and a file limit is not needed anymore. The search box can still be useful to filter the contents of the file explorer.

If you don't like that a compromise would be:

  • if the PR is small enough then render all files and the file explorer can be closed by default
  • if the PR is too large then render only the first file (one-by-one style) and the file explorer is open by default with the first file selected and showing ALL files affected in the PR

Not sure it this issue is a bug with regard to the file explorer or an improvement.

  • Robin Shen changed state to 'Closed' 1 year ago
    Previous Value Current Value
    Open
    Closed
  • Robin Shen commented 1 year ago

    This is by design. I filed a separate issue exploring approaches of display all files for large diff: OD-2191

issue 1/1
Type
Bug
Priority
Normal
Assignee
Affected Versions
11.5.3
Labels
No labels
Issue Votes (0)
Watchers (2)
Reference
OD-2187
Please wait...
Connection lost or session expired, reload to recover
Page is in error, reload to recover