Overview for all affected files when reviewing a commit (OD-2079)
empinator opened 1 year ago

If look through various commits and then click on a certain commit to review the details I automatically get a list of File-Diffs for each affected file within this commit.

If the amount of affected files is getting bigger it is hard identify certain files. It would be nice to have a file overview to see all affected files and then navigate to the diff-view by clicking on a filename.

  • Robin Shen commented 1 year ago

    This can be done via path filter:

    image.png

  • empinator commented 1 year ago

    If I put the cursor into the filter field, I do not get a list of affected files but only the option to search for files I might be looking for in comparison to an overview list all affected files

  • Robin Shen commented 1 year ago

    It will list all affected files organized hierarchically. And you may click the folder to see files affected inside it. And you can also search by pattern or file name.

  • empinator commented 1 year ago

    I don't know about you, but to me there is a difference between an auto-suggesting filter and an overview for investigation

    image_2.png

    I totally respect if you think that's not a considerable feature, since we can always use other git-tools in addition. I just thought it would be a minor change since the list of files is already known.

  • Robin Shen commented 1 year ago

    If the filter input does not contain any content, OneDev will display all files being affected. Just that you need to click the filter input to make it focused.

  • jbauer commented 1 year ago

    @empinator I feel your pain. I usually stick to a different Git tool to review changes directly on the PR branch and then only use OneDev to write code comments. The filter box is pretty inconvenient for larger changes. It is somewhat ok if you can review changes folder by folder but often you want to switch between folders. In that case you often have to switch between mouse and keyboard. While you can switch between searches using browser forward/backward you loose scroll position and always have to scroll to the file in question. It would also be helpful to mark a file as reviewed and then collapse it.

    In any case a mouse only interaction would be much faster and a file tree would always give you a visual context and easy switching between files / folders.

    However I can also understand that an additional file tree isn't easy to implement in the current UI because if costs horizontal space. Github solved it by moving everything else in a toolbar above. OneDev has its menu on the left which costs space. Maybe automatically collapse the menu could provide the space while in code review.

  • empinator commented 1 year ago

    @jbauer Indeed, you pretty much summarize the general need, but also the problem to have it embedded in the current layout

    @robin the filterbox, to me, feels like a fully collapsed folder structure I can't expand, but have to click through every folder

  • Robin Shen commented 1 year ago

    Thanks for all your input. Will see how this can be improved in future versions.

  • OneDev changed state to 'Closed' 1 year ago
    Previous Value Current Value
    Open
    Closed
  • OneDev commented 1 year ago

    State changed as code fixing the issue is committed (cc27c4d5)

  • OneDev changed state to 'Released' 1 year ago
    Previous Value Current Value
    Closed
    Released
  • OneDev commented 1 year ago

    State changed as build OD-5677 is successful

issue 1/1
Type
Improvement
Priority
Normal
Assignee
Labels
No labels
Issue Votes (1)
Watchers (3)
Reference
OD-2079
Please wait...
Connection lost or session expired, reload to recover
Page is in error, reload to recover