Issue comment: Exception on user autocomplete if issue creator is a deleted user (OD-2058)

jbauer opened 1 year ago

Trying to reference users in an issue comment results in an exception if the issue creator is a deleted/unknown user. Typing "@" is enough to trigger the issue.

java.lang.NullPointerException: null
	at io.onedev.server.util.facade.UserCache.getSimilarScore(UserCache.java:46)
	at io.onedev.server.web.component.comment.CommentInput$1.getSimilarScore(CommentInput.java:39)
	at io.onedev.server.web.component.comment.CommentInput$1.getSimilarScore(CommentInput.java:35)
	at io.onedev.server.util.Similarities.<init>(Similarities.java:21)
	at io.onedev.server.web.component.comment.CommentInput$1.<init>(CommentInput.java:35)
	at io.onedev.server.web.component.comment.CommentInput.lambda$getUserMentionSupport$0(CommentInput.java:35)
	at io.onedev.server.web.component.markdown.MarkdownEditor$7.respond(MarkdownEditor.java:409)
	at org.apache.wicket.ajax.AbstractDefaultAjaxBehavior.onRequest(AbstractDefaultAjaxBehavior.java:601)

OneDev changed state to 'Closed' 1 year ago
Previous Value Current Value
Open

Closed
OneDev commented 1 year ago

State changed as code fixing the issue is committed (b8ce8e3e)
OneDev changed state to 'Released' 1 year ago
Previous Value Current Value
Closed

Released
OneDev commented 1 year ago

State changed as build OD-5470 is successful
Login to comment

Previous Value	Current Value
Open	Closed

Previous Value	Current Value
Closed	Released

Type	Bug
Priority	Normal
Assignee	Robin Shen
Affected Versions	11.0.9
Labels	No labels

Issue Votes (0)

Watchers (2)

Reference

OD-2058