ImagePullPolicy "always" to "Always" (OD-1954)
m-onimura opened 2 years ago

While a bulid, I encountered a following error.

Kubernetes: The Pod "xxx" is invalid: xxx.xxx.imagePullPolicy: Unsupported value: "always": supported values: "Always", "IfNotPresent", "Never"

Command execution failed (command: kubectl create -f /opt/onedev/temp/server/k8s9757985897876130412.yaml -o jsonpath={.metadata.name}, exit code: 1)

I discovered the place which specify "always" to imagePullPolicy. https://github.com/theonedev/onedev/blob/0825f0b20a19a27f81fa03232324a69914a1e599/server-plugin/server-plugin-executor-kubernetes/src/main/java/io/onedev/server/plugin/executor/kubernetes/KubernetesExecutor.java#L746

I'm very happy if you change this "always".

Thank you for the great project.

  • OneDev changed state to 'Closed' 2 years ago
    Previous Value Current Value
    Open
    Closed
  • OneDev commented 2 years ago

    State changed as code fixing the issue is committed (3cb10ada)

  • OneDev changed state to 'Released' 2 years ago
    Previous Value Current Value
    Closed
    Released
  • OneDev commented 2 years ago

    State changed as build OD-5191 is successful

issue 1/1
Type
Bug
Priority
Normal
Assignee
Affected Versions
10.8.0
Labels
No labels
Issue Votes (0)
Watchers (2)
Reference
OD-1954
Please wait...
Connection lost or session expired, reload to recover
Page is in error, reload to recover