View code comments in pull request inline (OD-194)
Sebastien Collier opened 5 years ago

When doing a pull request review, it can be quite easy to miss code comments. It would be great if there was an option to expand comment threads in line, and have the ability to mark each thread as "resolved", similar to on GitHub.

  • Robin Shen commented 5 years ago

    We originally displayed pull request comments inline, but our team (OneDev is initially created for internal use in our company) feels that when there are discussions in the thread, it is hard to track what thread has new replies, and also inline comments making code reading somewhat difficult. So we changed the design to show comment as separate thread, and can bring you to the diff context following the link.

  • Sebastien Collier commented 5 years ago

    When viewing code through the "File Changes" tab, you need to look for a tiny icon to even realise there is a code comment, and click on each one individually. It can be quite easy to miss this when scrolling through a large code review:

    Screenshot From 2020 10 08 12 11 05

    Would it be possible to either:

    • add the inline code comments display back in as an option (similar to GitHub)
    • pop out a "Code Comments" side bar on the "File Changes" tab that displays all of the comment thread next to the relevant code snippets (similar to Google Docs)

    Additionally, it would be nice if the "Code Comments" tab displayed each code snippet with their comment thread all on the one page.

  • Robin Shen commented 5 years ago

    Adding two modes of showing code comments will make the code really complex.

    At our company, the reviewer checks file changes, adds relevant code comments. Then the author gets notified, opens each code comment to see code context, makes change and replies the comment as necessary. Then reviewer gets notification to review again, and so forth...

    This may not as convenient as GitHub inline comment mode initially, but for complex changes with many code comments, we feel that the review process is quite organized and never miss a reply.

  • Robin Shen changed state to 'Closed' 5 years ago
    Previous Value Current Value
    Open
    Closed
issue 1/1
Type
New Feature
Priority
Normal
Assignee
Issue Votes (0)
Watchers (3)
Reference
OD-194
Please wait...
Connection lost or session expired, reload to recover
Page is in error, reload to recover