Mask job secret value while editing (OD-1787)

Mask job secret value while editing #1787

Robin Shen opened 2 years ago

No description

Robin Shen changed title 2 years ago
Previous Value Current Value
Mask job secret value

Mask job secret value while editing
OneDev changed state to 'Closed' 2 years ago
Previous Value Current Value
Open

Closed
OneDev commented 2 years ago

State changed as code fixing the issue is committed (8cb9dfd1)

Copy
OneDev changed state to 'Released' 2 years ago
Previous Value Current Value
Closed

Released
OneDev commented 2 years ago

State changed as build #4795 is successful

Copy
bufferUnderrun changed state to 'Open' 2 years ago
Previous Value Current Value
Released

Open
bufferUnderrun commented 2 years ago

Hi Robin,

Why this setting has changed again ?? Maybe turn on/off three time in 4 years.

Hiding job secret value make the debugging of job harder as we don't know if the value is correct or up to date.

?

Copy
Robin Shen commented 2 years ago

Showing secret value is considered risky. Finally I decide to go with the GitHub style of hiding the value.

Copy
Robin Shen changed state to 'Closed' 2 years ago
Previous Value Current Value
Open

Closed
bufferUnderrun commented 2 years ago

@robin Maybe could it be an administrator option to show/hide job secret value (with default value to hide to keep fresh install as secure as you want) ?

Copy
Vyom commented 2 years ago

is there a way to show job secret in build? it is a lot harder to debug when working with job secrets.

Copy
Robin Shen commented 2 years ago

Please check this OD-1949

Copy
Login to comment

Previous Value	Current Value
Mask job secret value	Mask job secret value while editing

Previous Value	Current Value
Open	Closed

Previous Value	Current Value
Closed	Released

Previous Value	Current Value
Released	Open

Previous Value	Current Value
Open	Closed

Issue Votes (0)

Watchers (3)

Reference

OD-1787