OneDev
Dashboards
Projects
Global Views
Code Search
server
Code
Pull Requests
Issues
List
Boards
Iterations
Builds
Packages
Statistics
Child Projects
Audit Log
OneDev 14.1.0
Documentation Support & Bug Report RESTful API Incompatibilities License Agreement Check Update
Projects onedev server Issues OD-170
Updated OndDev Docker to 3.2.2 - still shows 3.2.1 (OD-170)
Michael Weimann opened 6 years ago

I have updated my OneDev instance (Docker image from Docker hub) to 3.2.2.
The application still shows 3.2.1.

Maybe there was something odd with the release?

  • Michael Weimann changed title 6 years ago
    Previous Value Current Value 
    Updated Docker to 3.2.2 - still shows 3.2.1
    		 
    Updated OndDev Docker to 3.2.2 - still shows 3.2.1
  • Robin Shen commented 6 years ago

    Just tested docker either with blank new install, or upgrade from 3.2.1, and correct version is displayed. Please check if the upgrade is successful following below procedure:

    1. Open a terminal to onedev server container docker exec -it <onedev server container id> bash
    2. Check file /opt/onedev/restore-db.log to see database is restored successfully without any errors
  • Michael Weimann commented 6 years ago

    Beside the version numer in the application interface new features are not there as well. E.g. issue templates or storing the web session.

    I double checked the image running; it is 3.2.2.

    Check file /opt/onedev/restore-db.log to see database is restored successfully without any errors

    I will do that later and report here.

  • Robin Shen commented 6 years ago

    Also you may try to delete the 3.2.2 image and pull again to see if it helps. Make sure to backup your database first.

  • Michael Weimann commented 6 years ago

    I destroyed the container and pulled the image.

    Then I started it again: OneDev 3.2.1 :/

    An ls of /opt/onedev/lib shows me

    io.onedev.server-product-3.2.1.jar

    Starting it locally on my machine in a fresh environment works.
    So I assume this is an update issue.

  • Robin Shen commented 6 years ago

    Does it show the correct version if you are running a blank new instance from your server machine?

  • Robin Shen commented 6 years ago

    Also please let me know how you are launching OneDev: is it launching from console with a tty attached? Or via some form of background service? If launching from console, you should see that OneDev is performing upgrade.

  • Michael Weimann commented 6 years ago

    Starting it with console output shows the hint ;)

    onedev_1  | INFO  - >>> INFO  - Validating data file 'IssueComments.xml'...
onedev_1  | INFO  - >>> ERROR - Error booting application
onedev_1  | INFO  - >>> java.lang.RuntimeException: org.dom4j.DocumentException: Error on line 2811 of document  : Character reference "&#
onedev_1  | INFO  - >>> 	at io.onedev.commons.utils.ExceptionUtils.unchecked(ExceptionUtils.java:36) ~[io.onedev.commons-utils-1.1.18.jar:na]
onedev_1  | INFO  - >>> 	at io.onedev.server.migration.VersionedXmlDoc.fromXML(VersionedXmlDoc.java:410) ~[io.onedev.server-core-3.2.2.jar:na]
onedev_1  | INFO  - >>> 	at io.onedev.server.migration.VersionedXmlDoc.fromFile(VersionedXmlDoc.java:416) ~[io.onedev.server-core-3.2.2.jar:na]
onedev_1  | INFO  - >>> 	at io.onedev.server.persistence.DefaultPersistManager.validateData(DefaultPersistManager.java:503) ~[io.onedev.server-core-3.2.2.jar:na]
onedev_1  | INFO  - >>> 	at io.onedev.server.maintenance.RestoreDatabase.doRestore(RestoreDatabase.java:93) ~[io.onedev.server-core-3.2.2.jar:na]
onedev_1  | INFO  - >>> 	at io.onedev.server.maintenance.RestoreDatabase.start(RestoreDatabase.java:69) ~[io.onedev.server-core-3.2.2.jar:na]
onedev_1  | INFO  - >>> 	at io.onedev.server.OneDev.start(OneDev.java:110) ~[io.onedev.server-core-3.2.2.jar:na]
onedev_1  | INFO  - >>> 	at io.onedev.commons.launcher.loader.DefaultPluginManager.start(DefaultPluginManager.java:44) ~[io.onedev.commons-launcher-loader-1.1.18.jar:na]
onedev_1  | INFO  - >>> 	at io.onedev.commons.launcher.loader.AppLoader.start(AppLoader.java:74) ~[io.onedev.commons-launcher-loader-1.1.18.jar:na]
onedev_1  | INFO  - >>> 	at io.onedev.commons.launcher.bootstrap.Bootstrap.main(Bootstrap.java:165) ~[io.onedev.commons-launcher-bootstrap-1.1.18.jar:na]
onedev_1  | INFO  - >>> Caused by: org.dom4j.DocumentException: Error on line 2811 of document  : Character reference "&#
onedev_1  | INFO  - >>> 	at org.dom4j.io.SAXReader.read(SAXReader.java:511) ~[org.dom4j.dom4j-2.1.3.jar:na]
onedev_1  | INFO  - >>> 	at org.dom4j.io.SAXReader.read(SAXReader.java:408) ~[org.dom4j.dom4j-2.1.3.jar:na]
onedev_1  | INFO  - >>> 	at io.onedev.server.migration.VersionedXmlDoc.fromXML(VersionedXmlDoc.java:408) ~[io.onedev.server-core-3.2.2.jar:na]
onedev_1  | INFO  - >>> 	... 8 common frames omitted
onedev_1  | INFO  - >>> Caused by: org.xml.sax.SAXParseException: Character reference "&#
onedev_1  | INFO  - >>> 	at com.sun.org.apache.xerces.internal.util.ErrorHandlerWrapper.createSAXParseException(ErrorHandlerWrapper.java:203) ~[na:1.8.0_252]
onedev_1  | INFO  - >>> 	at com.sun.org.apache.xerces.internal.util.ErrorHandlerWrapper.fatalError(ErrorHandlerWrapper.java:177) ~[na:1.8.0_252]
onedev_1  | INFO  - >>> 	at com.sun.org.apache.xerces.internal.impl.XMLErrorReporter.reportError(XMLErrorReporter.java:400) ~[na:1.8.0_252]
onedev_1  | INFO  - >>> 	at com.sun.org.apache.xerces.internal.impl.XMLErrorReporter.reportError(XMLErrorReporter.java:327) ~[na:1.8.0_252]
onedev_1  | INFO  - >>> 	at com.sun.org.apache.xerces.internal.impl.XMLScanner.reportFatalError(XMLScanner.java:1472) ~[na:1.8.0_252]
onedev_1  | INFO  - >>> 	at com.sun.org.apache.xerces.internal.impl.XMLScanner.scanCharReferenceValue(XMLScanner.java:1345) ~[na:1.8.0_252]
onedev_1  | INFO  - >>> 	at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl$FragmentContentDriver.next(XMLDocumentFragmentScannerImpl.java:3053) ~[na:1.8.0_252]
onedev_1  | INFO  - >>> 	at com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl.next(XMLDocumentScannerImpl.java:602) ~[na:1.8.0_252]
onedev_1  | INFO  - >>> 	at com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.next(XMLNSDocumentScannerImpl.java:112) ~[na:1.8.0_252]
onedev_1  | INFO  - >>> 	at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:505) ~[na:1.8.0_252]
onedev_1  | INFO  - >>> 	at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:842) ~[na:1.8.0_252]
onedev_1  | INFO  - >>> 	at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:771) ~[na:1.8.0_252]
onedev_1  | INFO  - >>> 	at com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:141) ~[na:1.8.0_252]
onedev_1  | INFO  - >>> 	at com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1213) ~[na:1.8.0_252]
onedev_1  | INFO  - >>> 	at com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl$JAXPSAXParser.parse(SAXParserImpl.java:643) ~[na:1.8.0_252]
onedev_1  | INFO  - >>> 	at org.dom4j.io.SAXReader.read(SAXReader.java:494) ~[org.dom4j.dom4j-2.1.3.jar:na]
onedev_1  | INFO  - >>> 	... 10 common frames omitted
onedev_1  | ERROR - Failed to upgrade /opt/onedev
onedev_1  | INFO  - Restoring old program files due to upgrade failure...
onedev_1  | INFO  - Old program files restored
onedev_1  | WARN  - The database might be in an inconsistent state due to upgrade failure. In that case, you need to restore the database by first cleaning it, and then running below command:

    I assume restoring the backup doesn't help here. Looks like one of my comments contains an evil character.

  • Robin Shen commented 6 years ago

    Can you help to reproduce this issue with a sample instance, and attach the backup for diagnostics?

  • Michael Weimann commented 6 years ago

    I found out that if you post an ampersand followed by a hash without code(block) markdown the JavaScript crashes.

    The log above points out that the problem is somehow there. I posted the comment into a different environment. JS errors occur. DB errors not :(

    Anyway here is the xml comment node from the backup producing the issue:
    Broken Comment

  • Robin Shen commented 6 years ago

    Do you mean this?

    &#

    It is working fine

  • Robin Shen commented 6 years ago

    Reproduced JS error

  • Michael Weimann commented 6 years ago

    Reproduced JS error

    👍

    Could you get something out of the exported issue comment causing the DB trouble?

  • Robin Shen commented 6 years ago

    Yes, DB issue also found. It turns out that some special html characters are not valid XML 1.0 char. Once parse with 1.1 it will be fine.

  • Robin Shen changed state to 'Closed' 6 years ago
    Previous Value Current Value 
    Open
    		 
    Closed
  • Robin Shen commented 6 years ago

    Fixed in build #880

  • Michael Weimann commented 6 years ago

    The update worked 👍 Thanks

issue 1/1
Type
Question
Priority
Normal
Assignee
Robin Shen
Issue Votes (0)
Login to vote
Watchers (3)
Reference
OD-170
Please wait...
Connection lost or session expired, reload to recover
Page is in error, reload to recover