Copying issue title results in first character being lower case (OD-1639)
jbauer opened 2 years ago

Copy the title of any issue starting with upper case character using the copy icon: https://code.onedev.io/onedev/server/~issues?query=%22State%22+is+%22Open%22

Paste the copied text somewhere and the first character will always be lower case.

  • Robin Shen commented 2 years ago

    It is intentionally changed to lowercase to facilicate copying into commit message after conventional commit verbs.

  • jbauer commented 2 years ago

    I see. As far as I know lower case isn't required for conventional commit message after the verb. I guess you just see it everywhere because of English language. But even with English language this can cause trouble. Personally I was annoyed by it because I often have issues like NPE in class.method:line or IAOBE in class.method:line. Copying these messages and making the first letter lowercase is bad then.

    Also in other languages it feels unnatural to start with a lower case letter, even in commit messages. I have just taken a look at our commit messages of different developers and they all start with upper case letter after the conventional commit verb. For example in German nouns are always written with upper case letter. If commit message starts with a noun having a lower case letter it is wrong.

    Maybe make it configurable?

  • Robin Shen commented 2 years ago

    You are right that the convenentional commit does not put any restrictions on commit subject cases. Will revert it back.

  • OneDev changed state to 'Closed' 2 years ago
    Previous Value Current Value
    Open
    Closed
  • OneDev commented 2 years ago

    State changed as code fixing the issue is committed (ea20d4eb)

  • OneDev changed state to 'Released' 2 years ago
    Previous Value Current Value
    Closed
    Released
  • OneDev commented 2 years ago

    State changed as build #4330 is successful

issue 1/1
Type
Bug
Priority
Minor
Assignee
Affected Versions
9.2.5
Labels
No labels
Issue Votes (0)
Watchers (3)
Reference
OD-1639
Please wait...
Connection lost or session expired, reload to recover
Page is in error, reload to recover