onedev/server

Issue attachments gone - error 500 (OD-156)

The issue attachments in one of my OneDev environments are gone.
They have been there before. It is only the case for some issues not for all.

Loading the image URL shows me

HTTP ERROR 500 Attachment not found: image_2.png
URI:	/projects/secret/attachment/53ce0b24-951e-8f3b-86f0-7c1e0291d649/image_2.png
STATUS:	500
MESSAGE:	Attachment not found: image_2.png
SERVLET:	io.onedev.server.web.DefaultWicketServlet$$EnhancerByGuice$$b27a2b57-4da5d095

If there is anything I can do for debugging let me know @robin

Robin Shen commented 6 years ago

Looks odd. Checked the code and can not find obvious reason yet. Can you please help to investigate to see if it can be reproduced?

Attachment storage is managed via class DefaultAttachmentStorageManager. When an issue is about to create, attached images are placed into a temp folder, and when the issue is saved, it will be moved to a permanent folder. The temp folder will be deleted after some time via a schedule.
Robin Shen commented 6 years ago

@mweimann Is the missing image in issue description, or issue comment?
Michael Weimann commented 6 years ago
@robin both.

Things are getting more strange:

Yesterday evening the images have been there (have to check whether they have been served from the browser cache)

Today they are gone

I will do a deeper analysis later.
Robin Shen commented 6 years ago

@mweimann never mind, find the problem
Robin Shen changed iterations 6 years ago
Previous Value Current Value
empty
3.2.1
OneDev changed state to 'Closed' 6 years ago
Previous Value Current Value
Open

Closed
OneDev changed state to 'Released' 6 years ago
Previous Value Current Value
Closed

Released
Michael Weimann commented 6 years ago

Updated to 3.2.1 - today the images are missing again.
Robin Shen commented 6 years ago

At my side the problem happens when an issue is created prior to 3.2.1 with no images attached in description. And if later an image is attached to the comment or description of the issue, the image will be missing after 24 hours. However for new issues created after 3.2.1, the problem should no longer be happening.

Please check if this is the case at your side. If yes, I can modify the code to preserve the images.
sev referenced from other issue 10 months ago

`markdown-image-loading` doesn't go away (OD-2346)

Released
Login to comment

Previous Value	Current Value
empty	3.2.1

Previous Value	Current Value
Open	Closed

Previous Value	Current Value
Closed	Released

Type	Bug
Priority	Normal
Assignee	Robin Shen
Affected Versions	Not Found

Iterations

3.2.1 Closed

Issue Votes (0)

Watchers (3)

Reference

OD-156