onedev/server

#1458 Pull Request: Code comment can cause horizontal scrollbar

Released

jbauer opened 10 months ago

Take a look at

https://code.onedev.io/jbauer/~pulls/2/changes?old-commit=94fb78258177bfd29993d45b5aaae217a36c2a26&new-commit=6707bf7228b927afa0d4ce28be53d36fe2abb2b8&comment=158&mark=6707bf7228b927afa0d4ce28be53d36fe2abb2b8~Test.java~8.2-8.32-1

Maybe you want to fix that.

Robin Shen commented 10 months ago

I'd rather to leave this as is. Using text-break instead of word-break to break long text at any character boundary will make the code less readable just to avoid horizontal scroll bar.

jbauer commented 10 months ago

I thought it might be consistent with the behavior of code suggestion which seems to break at letters as seen in the link above. Usually the issue appears if you have some code line inline in the comment because code lines usually do not contain many white space.

Robin Shen commented 10 months ago

Well.. For consistency, will change as proposed.

OneDev changed state to 'Closed' 10 months ago

Previous Value	Current Value
Open	Closed

OneDev commented 10 months ago

State changed as code fixing the issue is committed (60fe3e5f)

OneDev changed state to 'Released' 10 months ago

Previous Value	Current Value
Closed	Released

OneDev commented 10 months ago

State changed as build #3909 is successful

Type	Improvement
Priority	Minor
Assignee	Robin Shen

Issue Votes (0)

Watchers (4)

Reference

onedev/server#1458