Able to use k8s helper image from custom registry (OD-1408)

Released

onedevtest2023 opened 11 months ago

I see a job use kubernetes executor will create namespace ( name like '<kubernetes_executor_name>-1-8-0' ) , run a pod (name is 'job'). The pod container initContainers and sidecar 's image name is 1dev/k8s-helper-linux:2.10.8 (onedev version is 8.2.6). Because my server cannot pull image from docker.io, I will manually pull 1dev/k8s-helper-linux:2.10.8 to internal image registry, and use internal image name, like 'x.x.x.x/1dev/k8s-helper-linux:2.10.8'. How could I change the job_pod initContainers and sidecar's image name?

Robin Shen commented 11 months ago

Thanks for trying OneDev. Currently there is no way to use custom helper image. Will make this configurable in next patch release.

Robin Shen changed title 11 months ago

Previous Value	Current Value
hwo to set kubernetes executor helper image name	Able to use k8s helper image from custom registry

Robin Shen changed fields 11 months ago

Name	Previous Value	Current Value
Type	Bug	Improvement

Referenced from commit 11 months ago

feat: able to use k8s helper image from custom registry (onedev/server#1408 )

Robin Shen committed 11 months ago

in onedev/agent

cd5c583b

OneDev changed state to 'Closed' 11 months ago

Previous Value	Current Value
Open	Closed

OneDev commented 11 months ago

State changed as code fixing the issue is committed (7c569124)

OneDev changed state to 'Released' 11 months ago

Previous Value	Current Value
Closed	Released

OneDev commented 11 months ago

State changed as build #3725 is successful

Robin Shen commented 11 months ago

With 8.3.5, you can map k8s helper image from official registry to your own registry via image mappings in more settings of k8s executor.

Please note that different OneDev server may use different k8s helper version. For instance OneDev 8.3.5 uses k8s helper version 2.10.13. This relationship can be found via pom.xml via dependency chain io.onedev.server -> io.onedev.agent -> io.onedev.k8s-helper.

Type	Improvement
Priority	Major
Assignee	Robin Shen

Issue Votes (0)

Watchers (4)

Reference

OD-1408