wojtek
opened 3 years ago
-
less:
vim
-
1dev 7.9.3:
-
Upgrading to latest 8.2.6 yields the same problem.
I'm not sure that info at the end:
OneDev is unable to restore old database, please do it manually by first resetting it (delete and create), and then running below command: /opt/onedev/bin/restore-db.sh /opt/onedev/site/db-backup/2023-05-25_23-54-35.zipWould change anything.
-
Btw. what is the recommended option for HA to avoid crash / system downtime?
-
Seems that some characters in your database are treated as invalid chars in XML. Can you please attach
Issues.xml.6here? I will check what might be wrong, and fix it so that you can continue to restore. -
Previous Value Current Value false
true
-
I have changed the issue as confidential so that no one else can see the file.
-
Btw. what is the recommended option for HA to avoid crash / system downtime?
This feature is already in EE version, which will be released in the end of this year.
-
As said earlier it's unicode symbol U+FFFF which is invalid. Oddly enough 1dev doesn't accept it in the comment (it got into 1dev via import).
Here's the short/cut file with single line as it doesn't make sense to upload complete file...
Could you give more information about the EE version? Any link to ticket?
-
OneDev
changed state to 'Closed' 3 years ago
Previous Value Current Value Open
Closed
-
State changed as code fixing the issue is committed (8c830375)
-
Previous Value Current Value true
false
-
OneDev
changed state to 'Released' 3 years ago
Previous Value Current Value Closed
Released
-
State changed as build #3659 is successful
-
You may restore the backup with 8.2.7 to get around the issue.
-
Could you give more information about the EE version? Any link to ticket?
Features currently included in EE version:
- Custom dashboard
- Separate storage for LFS and artifacts
- Open web terminal to analyze build failure
- Clustering and replication to distribute OneDev projects to different servers for performance and reliability purpose
- Cross project code search
-
You may restore the backup with 8.2.7 to get around the issue.
Thank you. I took a look at the commit and it seems to fix the issue, though to avoid data-loss - could we maybe replace invalid string with string representation akin vim's: <00ffff>? Or like in the exception message:
(Unicode: 0xffff)Context - it was a bug report, so we fixed it but we knew what the character was.
Could you give more information about the EE version? Any link to ticket?
Features currently included in EE version:
Thanks. I assume those EE would stand for Enterprise Edition?
-
I tried
8.2.7version:$ kubectl describe deployments.apps/onedev Name: onedev Namespace: onedev-prod CreationTimestamp: Mon, 07 Feb 2022 14:47:45 -0300 … Containers: onedev: Image: 1dev/server:8.2.7But it failed with the same exception:
INFO - >>> INFO - Restoring database from /opt/onedev/site/db-backup/2023-05-26_16-20-59.zip... INFO - >>> INFO - Creating tables... INFO - >>> INFO - Importing data into database... INFO - >>> INFO - Importing from data file 'Roles.xml'... INFO - >>> INFO - Importing from data file 'LabelSpecs.xml'... INFO - >>> INFO - Importing from data file 'ProjectUpdates.xml'... INFO - >>> INFO - Importing from data file 'Projects.xml'... INFO - >>> INFO - Importing from data file 'Users.xml'... INFO - >>> INFO - Importing from data file 'Issues.xml.12'... INFO - >>> INFO - Importing from data file 'Issues.xml.10'... INFO - >>> INFO - Importing from data file 'Issues.xml'... INFO - >>> INFO - Importing from data file 'Issues.xml.7'... INFO - >>> INFO - Importing from data file 'Issues.xml.5'... INFO - >>> INFO - Importing from data file 'Issues.xml.9'... INFO - >>> INFO - Importing from data file 'Issues.xml.3'... INFO - >>> INFO - Importing from data file 'Issues.xml.2'... INFO - >>> INFO - Importing from data file 'Issues.xml.11'... INFO - >>> INFO - Importing from data file 'Issues.xml.14'... INFO - >>> INFO - Importing from data file 'Issues.xml.8'... INFO - >>> INFO - Importing from data file 'Issues.xml.4'... INFO - >>> INFO - Importing from data file 'Issues.xml.13'... INFO - >>> INFO - Importing from data file 'Issues.xml.6'... INFO - >>> ERROR - Error booting application INFO - >>> java.lang.RuntimeException: org.dom4j.DocumentException: Error on line 37770 of document : An invalid XML character (Unicode: 0xffff) was found in the element content of the document. INFO - >>> at io.onedev.commons.bootstrap.Bootstrap.unchecked(Bootstrap.java:341) INFO - >>> at io.onedev.commons.utils.ExceptionUtils.unchecked(ExceptionUtils.java:35) INFO - >>> at io.onedev.server.migration.VersionedXmlDoc.fromXML(VersionedXmlDoc.java:417) INFO - >>> at io.onedev.server.migration.VersionedXmlDoc.fromFile(VersionedXmlDoc.java:423) INFO - >>> at io.onedev.server.persistence.DefaultDataManager.importData(DefaultDataManager.java:541) INFO - >>> at io.onedev.server.persistence.SessionInterceptor$1.call(SessionInterceptor.java:23) INFO - >>> at io.onedev.server.persistence.DefaultSessionManager.call(DefaultSessionManager.java:90) INFO - >>> at io.onedev.server.persistence.SessionInterceptor.invoke(SessionInterceptor.java:18) INFO - >>> at io.onedev.server.commandhandler.RestoreDatabase.doRestore(RestoreDatabase.java:125) INFO - >>> at io.onedev.server.commandhandler.RestoreDatabase.start(RestoreDatabase.java:79) INFO - >>> at io.onedev.commons.loader.DefaultPluginManager.start(DefaultPluginManager.java:44) INFO - >>> at io.onedev.commons.loader.AppLoader.start(AppLoader.java:60) INFO - >>> at io.onedev.commons.bootstrap.Bootstrap.main(Bootstrap.java:204)
| Type |
Bug
|
| Priority |
Normal
|
| Assignee | |
| Affected Versions |
7.9.12
|
I tried to upgrade 7.9.3->7.9.12 (I'm aware that there are newer versions, but I intended to avoid jumping too much) and it result in following exception:
I get the backup file, extracted the files and checked
Issues.xml.6file, and the mentioned line has this (view invim):I'm going to try to upgrade to the latest version, but considering there wasn't any similar issue it will probably still happen.