Conventional commit rule of branch protection should allow default git revert message (OD-1368)
Released
jbauer opened 1 year ago

Conventional commits does not specify the revert commit. See: https://github.com/conventional-commits/conventionalcommits.org/issues/88

They recommend using a revert type as it matches the current spec but do not force it. This is kind of fine if you use git on command line since by default git revert lets you edit the commit message. However many people are using Git UI tools which do not allow editing the message right away when reverting a commit and the tool uses the default git message which is

Revert "fix(core): some text"

This reverts commit <hash>

Asking developers to manually change the message from Revert "fix(core): some text" to revert: fix(core): some text just to satisfy the spec could feel like useless extra work, as the default git behavior is already pretty good. Especially in UI tools it requires some extra clicks to do so.

So I think OneDev should always allow the default git revert message for simplicity and good out of the box behavior.

OneDev changed state to 'Closed' 11 months ago
Previous Value Current Value
Open
Closed
OneDev commented 11 months ago

State changed as code fixing the issue is committed (7fcb16e6)

OneDev changed state to 'Released' 11 months ago
Previous Value Current Value
Closed
Released
OneDev commented 11 months ago

State changed as build #3693 is successful

issue 1 of 1
Type
Improvement
Priority
Normal
Assignee
Issue Votes (0)
Watchers (4)
Reference
OD-1368
Please wait...
Page is in error, reload to recover