Latest build doesn't list properly 'Fixed Issues' and 'Changes' (OD-1363)
Released
Máté Novak opened 1 year ago

Hi all,

First of all, thanks for this amazing tool!

I think I am experiencing a bug but I want to be sure about it first. I've been creating builds on the master branch and incrementing version numbers between them for the last couple of months. All the latest builds went okay, and fixed issues were listed between different versions perfectly.

Now, today after I created our last version (let's call it 7.3.1) and it does not include latest fixes but also includes all fixed issues since the latest version, let's call it 7.1.4. But the issue is that there was a version 7.3.0 in the middle of it. The listed issues for 7.1.4 build are good, for 7.3.0 too, now is with 7.3.1 we have this problem on where all issues that were listed in 7.3.0 are listed all over again on the 'Fixed Issues' section - furthermore, if I go to 'Changes' and scroll down, I can see commit of 7.3.0 in the middle of other commits, which should mean that stream is the same right? So what is going on? At the bottom it says 'This page lists fixed issues since previous successful build on same stream' and that says: same project, same job, and same branch. For us that's true in all three cases.

Any help/comments that might help us to understand what might be happening would be awesome. Thanks!

Máté

Robin Shen commented 1 year ago

Previous build used to calculate fixed issues should be ancestor of current build.

Seems that build 7.3.0 is not ancestor of build 7.3.1. Is 7.3.1 rebased or squashed and its parent point to 7.1.4 instead?

(By mentioning build, I actually mean commit associated with that build).

Máté Novak commented 1 year ago

Hi Robin,

Actually, 7.3.0 is a direct ancestor of build 7.3.1, that's why I can see it in the 'Changes' section of the 7.3.1 build. But instead of stopping in the commit preceding 7.3.0, it goes all the way until 7.1.4.

I think we have found a reasonable explanation for what is happening. We keep a separate branch for production (only hotfixes), which has the latest 7.2.x builds, which also includes 7.1.4 and back. Prior to the release of 7.3.1 (from master), we merged the production branch into master. If you follow that merge commit you can reach all the way down until 7.1.4. This probably makes sense on why 7.3.0 issues appeared on the list, but if this is the case, shouldn't all the hotfixes fixed in 7.2.x will be included too? I'm confused. Because the 'Changes' section of 7.3.1 shows a clear path from 7.3.1 all the way down until 7.1.4 but from the master branch only. Let me know if there's any data I can provide to analyse this deeper.

Máté

OneDev changed state to 'Closed' 1 year ago
Previous Value Current Value
Open
Closed
OneDev commented 1 year ago

State changed as code fixing the issue is committed (c29c8bd9)

OneDev changed state to 'Released' 1 year ago
Previous Value Current Value
Closed
Released
OneDev commented 1 year ago

State changed as build #3622 is successful

Robin Shen commented 1 year ago

Thanks for the info. Turns out that a build in your production branch was picked as previous build of 7.3.1, which is incorrect. This issue has now been fixed by comparing branch name when search for previous build.

Máté Novak commented 1 year ago

Robin,

That's awesome news! So, after installing 8.1.6 can I re-run the latest build and should list issues properly right?

Máté

Robin Shen commented 1 year ago

Yes that is true, as long as all your 7.2.x builds are fired off production branch to not confusing OneDev.

issue 1 of 1
Type
Bug
Priority
Normal
Assignee
Affected Versions
8.1.4
Issue Votes (0)
Watchers (3)
Reference
OD-1363
Please wait...
Page is in error, reload to recover