Filip Strajnar
opened 3 years ago
-
I plan to move docker-compose.yaml into https://code.onedev.io/onedev/server/~files/main/server-product/docker, and this file will be published together with other artifacts like this: https://code.onedev.io/onedev/server/~builds/3602/artifacts
However I do not think there is much value for separate setup.py/setup.sh whose purpose is only to generate password for database and OneDev administrator, which adds complexities (you need to write docs for it to tell user what it is...). For database password, if we do not open the 3306 port, it should be fine to use a default password, and for OneDev adminsitrator, you may comment out various initial environments, and OneDev will prompt user to input password when it starts up for the first time. Also I think it is easier to modify docker-compose.yaml if you want to change it. They can use any password they want.
-
docker-compose.yamlhas now been moved to directoryserver-product/dockerwith some modifications:- Use
exposeinstead ofportsfor postgresql service port to make it only accessible from within other containers. - Use
./docker/site/postgresinstead of./postgresto store postgresql database so that we only need one external data directory - Make container
onedevdepends onpostgresto ganrantee correct container startup order
- Use
-
Previous Value Current Value Open
Closed
| Type |
Improvement
|
| Priority |
Minor
|
| Assignee |
I was told to contribute on this repository instead of GitHub, so I decided to open an issue here. I will modify the docker compose script to use postgres, but I'd also want to ask if the following idea is good: I propose I'd make a top level directory called docker, in which there would be a
setup.pyandsetup.shfile, which would generate a secure random password (for exampleopenssl rand -hex 32) for both admin user, and the database. It would effectively render adocker-compose.yamlfile that's already reasonably secure to deploy. This way there would be no need for those extra comments withindocker-compose.yamlfile. If this suggestion is bad, or if there is a better way to go about it, let me know.