#1342  Show pull request info in build list page
Released
jbauer opened 1 year ago

When pull requests (or other things) trigger a build it would be nice if the "Submit Reason" field in the build details page would link back to the reason if possible, e.g. link back to the pull request, so I can directly navigate to the PR.

Also it would be valuable to show the build reason column (also as link, if possible) in the builds overview page that lists all builds of a project (or globally all projects). This would give more information for merge commit preview builds of pull requests. Currently you can only see the job name, e.g. "CI", and the branch/tag column shows "n/a" for these kind of builds.

jbauer commented 1 year ago

Additionally when you enable Require Strict Pull Request Builds in branch protection rules and you run a required build manually from within the pull request UI, the build reason should be linked with this pull request. Currently it only states "started manually"

Robin Shen commented 1 year ago

When pull requests (or other things) trigger a build it would be nice if the "Submit Reason" field in the build details page would link back to the reason if possible, e.g. link back to the pull request, so I can directly navigate to the PR.

There is a pull request section in build detail page at right side of the screen.

Also it would be valuable to show the build reason column (also as link, if possible) in the builds overview page that lists all builds of a project (or globally all projects). This would give more information for merge commit preview builds of pull requests. Currently you can only see the job name, e.g. "CI", and the branch/tag column shows "n/a" for these kind of builds.

This will be improved in next patch release.

Additionally when you enable Require Strict Pull Request Builds in branch protection rules and you run a required build manually from within the pull request UI, the build reason should be linked with this pull request. Currently it only states "started manually"

Started manually accurately reflects the build submit reason. You can know that this links to a pull request in pull request section of build.

Robin Shen changed title 1 year ago
Previous Value Current Value
Build details UI: Field "Submit Reason" could link back to, e.g. Pull Request.
Show pull request info in build list page
OneDev changed state to 'Closed' 1 year ago
Previous Value Current Value
Open
Closed
OneDev commented 1 year ago

State changed as code fixing the issue is committed (a4362dde)

OneDev changed state to 'Released' 1 year ago
Previous Value Current Value
Closed
Released
OneDev commented 1 year ago

State changed as build #3594 is successful

jbauer commented 1 year ago

When pull requests (or other things) trigger a build it would be nice if the "Submit Reason" field in the build details page would link back to the reason if possible, e.g. link back to the pull request, so I can directly navigate to the PR.

There is a pull request section in build detail page at right side of the screen.

Yes, maybe my wording was bad. I meant that it should be a hyperlink so I can directly navigate to the pull request. Currently it is only text.

jbauer commented 1 year ago

Oh sorry, I see what you mean. Somehow my focus was on the top half of the sidebar and didn't noticed the pull request section below it. Maybe just both locations should be hyperlinks.

Robin Shen commented 1 year ago

Please solely rely on pull request section for pull request reference. Pull request number in submit reason will be removed for brevity.

issue 1 of 1
Type
Improvement
Priority
Normal
Assignee
Issue Votes (0)
Watchers (4)
Reference
onedev/server#1342
Please wait...
Page is in error, reload to recover