Dynamic storage directory for site data (OD-1323)

Unknown opened 3 years ago

Allow for site data, to be moved to anywhere on the disk, do not defaultly stick it in /opt/onedev as it is stupid and results in issue #1322

Activities

OneDev referenced from other issue 3 years ago

Latest version (8.0.15) non-updatable and lost all data (OD-1322)

Closed
Unknown commented 3 years ago

This can be through environment variables such as ONEDEV_DATA=/var/onedev or through some configuration file, but whatever the case this needs to be added, and if it is added, used by default!

And if it is also added already, make it bold in the configuration settings to not store data in the source code directory.
Robin Shen changed fields 3 years ago
Name Previous Value Current Value
Type

Bug

Discussion
Robin Shen changed fields 3 years ago
Name Previous Value Current Value
Priority

Critical

Normal
Robin Shen commented 3 years ago

If you follow the official upgrade procedure and script, it is impossible to lost data. Your own customized upgrade procedure should NOT credit to OneDev official distribution.
Robin Shen changed state to 'Closed' 3 years ago
Previous Value Current Value
Open

Closed
Unknown commented 3 years ago

I do not know how that has any relationship,

There is a VERY good reason Linux stores its code/binaries an its data separately, its to prevent accidental damage of data.

This feature is critical, and at this point it is a deal breaker.

The damage to the site directory was probably my fault and not the update script, but the update script failed and my manual intervention destroyed the data.

Data should NEVER be stored in the same directory.
Robin Shen commented 3 years ago

Storing code and data together works the best for OneDev's installation and upgrade. I do not need to confirm to any standard here, as long as it is simple and reliable.
Robin Shen commented 3 years ago

Correct: I think there is no standard here, just convention
Unknown commented 3 years ago

This issue is prone to human mistake during the update, obviously I accidentally did something wrong in a rush, but this couldnt be possible if you stored data separately.

Seems onedev just wants to be simple, obviously I have misunderstood its use case.
Robin Shen commented 3 years ago

As I said, OneDev tries to be RELIABLE and simple. If you follow the official upgrade guide, it is impossible to lost data.
Login to comment

Name	Previous Value	Current Value
Type	Bug	Discussion

Name	Previous Value	Current Value
Priority	Critical	Normal

Previous Value	Current Value
Open	Closed

Type	Question
Priority	Normal
Assignee	Robin Shen

Issue Votes (0)

Watchers (3)

Reference

OD-1323