Avoid sending multiple e-mails to same recipients for same build (Bug: Issue submitted twice?) (OD-1317)
Closed
Jerome St-Louis opened 1 year ago

Being subscribed in Saved queries to Failed builds plus having the rule in postBuildActions as committers seems to cause 2 e-mails to be sent to same recipient.

Jerome St-Louis commented 1 year ago

New bug: how did I end up submitting this issue twice? ! :)

Jerome St-Louis changed title 1 year ago
Previous Value Current Value
Avoid sending multiple e-mails to same recipients for same build
Avoid sending multiple e-mails to same recipients for same build (Bug: Issue submitted twice?)
Jerome St-Louis commented 1 year ago

I do have a very tired left mouse button, so perhaps I accidentally clicked twice on the Create button, but both the client and the server should have prevented that.

Robin Shen changed state to 'Closed' 1 year ago
Previous Value Current Value
Open
Closed
Robin Shen commented 1 year ago

I guess this is caused by multiple submissions of the same issue.

As to sending multiple emails for same build, they have different purpose. Normally different group/user subscribes with different approach.

Jerome St-Louis commented 1 year ago

@robin How was I able to submit the same issue multiple times though?

I definitely did not do it on purpose, and it was from the same click on the same button (though my misbehaving mouse might have sent two clicks).

Neither the client nor the server detected that I clicked on the "submit" button twice.

There is a bug to fix here for sure! I would fix it at both the client and server, but at least one of them should be fixed :)

It should not be possible to create two issues from the very same text box and button.

Jerome St-Louis commented 1 year ago

As to sending multiple emails for same build, they have different purpose. Normally different group/user subscribes with different approach.

But the server should be smart enough and detect a recipient in both categories for the same build.

Robin Shen commented 1 year ago

The resubmission should happen rarely. I guess many of the UI issues you seen here are related to the UI busy issue for your browser on X window, and this will be fixed by using a non-zero timeout.

There are edge cases and the fix can be pretty complex. as long as it does not do much harm, I'd rather leave it as is.

For multiple emails sending to same recipient issue for a single build, please reopen if you find it is a real issue in production use.

issue 1 of 1
Type
Improvement
Priority
Normal
Assignee
Issue Votes (0)
Watchers (4)
Reference
OD-1317
Please wait...
Page is in error, reload to recover