|
jbauer opened 1 year ago
|
||||
|
This link is "changes since last visit" which serves its purpose. To show changes since last review. Use the link below:
This icon exists for every activity. So it is easy to see what have been changed since. |
||||
|
|
Oh ok, that is quite unintuitive. My coworkers and myself never noticed that icon given that it is hidden and only visible on mouse hover. Form a usability standpoint showing a big link after someone has updated a pull request and then removing that link immediately once you leave that UI view and replacing that link with a hidden icon isn't great. All my coworkers have complained that the link is gone as soon as you leave the UI and were annoyed by it. I can understand that hiding the icon makes sense for old changes to not clutter the UI. But I feel like the UI for the most recent changes of a pull request should visually always stay the same until the user has made some action, e.g. hitting the request for changes button or approving the pull request. |
||||
|
|
Robin Shen changed state to 'Closed' 1 year ago
|
||||
|
|
The diff icon is independent of the "changes since last visit", and is always there, even for old actions (in case you want to see changes since that). |
| Type |
Improvement
|
| Priority |
Normal
|
| Assignee |
When someone updates a pull request OneDev shows a link "Changes since last review". However that link is only shown exactly once when you first visit the updated pull request. As soon as you navigate away by either clicking the link or visiting some other OneDev section (e.g. looking at code comments if there are answers) and then come back to the pull requests Activities tab, the link is gone.
Would be nice to have that link always visible or maybe only remove it if "merge", "discard" or "request changes" button is clicked.
The link should be visible as long as my review takes.