Re: [Issue onedev/server#1199] (Updated) prometheus monitoring (OD-1207)

Unknown opened 3 years ago

Ah, I am working on a Java wrapper... mind linking the golang wrapper...?

Activities

Robin Shen commented 3 years ago

Unless someone has interest working on that...
Unknown commented 3 years ago

On 16 February 2023 02:00:58 GMT,
Robin Shen commented 3 years ago

When you reply an issue, it should be send to address like [email protected], which will never create a new issue. Only when you send email to [email protected] will create a new issue, which is unlikely unless intentionally.
Unknown commented 3 years ago

Yes, but sometimes you accidentally reply all

Nobody will ever start an issue with RE, as it is reserved within the subject for responses.
Marcos de Oliveira commented 3 years ago

I think your e-mail client might be misbehaving... Like, Gmail does not even have a reply-all if there is one/zero (Onedev send as Bcc, so zero) recipient. Outlook does have it, but it still respects Reply-To...
Unknown commented 3 years ago

I think your e-mail client might be misbehaving... Like, Gmail does not even have a reply-all if there is one/zero (Onedev send as Bcc, so zero) recipient. Outlook does have it, but it still respects Reply-To...

It doesn't matter if it is or not, it is not properly sanatising inputs if it permits RE in the email subject.
Robin Shen commented 3 years ago

I think it is reasonable to filter off titles starting with RE:

Will modify as @polarian suggested.
Unknown commented 3 years ago

Thanks Robin, shouldn't be a big change, a simple if statement :)
Robin Shen changed state to 'Closed' 3 years ago
Previous Value Current Value
Open

Closed
Robin Shen commented 3 years ago

Tracked via issue #1214 Closing this now.
Login to comment

Previous Value	Current Value
Open	Closed

Type	Question
Priority	Normal
Assignee	Robin Shen

Issue Votes (0)

Watchers (4)

Reference

OD-1207