#1207  Re: [Issue onedev/server#1199] (Updated) prometheus monitoring
Closed
Unknown opened 1 year ago

Ah, I am working on a Java wrapper... mind linking the golang wrapper...?

Robin Shen commented 1 year ago

Unless someone has interest working on that...

Unknown commented 1 year ago

On 16 February 2023 02:00:58 GMT,

Robin Shen commented 1 year ago

When you reply an issue, it should be send to address like support+issue~1264@onedev.io, which will never create a new issue. Only when you send email to support@onedev.io will create a new issue, which is unlikely unless intentionally.

Unknown commented 1 year ago

Yes, but sometimes you accidentally reply all

Nobody will ever start an issue with RE, as it is reserved within the subject for responses.

Marcos de Oliveira commented 1 year ago

I think your e-mail client might be misbehaving... Like, Gmail does not even have a reply-all if there is one/zero (Onedev send as Bcc, so zero) recipient. Outlook does have it, but it still respects Reply-To...

Unknown commented 1 year ago

I think your e-mail client might be misbehaving... Like, Gmail does not even have a reply-all if there is one/zero (Onedev send as Bcc, so zero) recipient. Outlook does have it, but it still respects Reply-To...

It doesn't matter if it is or not, it is not properly sanatising inputs if it permits RE in the email subject.

Robin Shen commented 1 year ago

I think it is reasonable to filter off titles starting with RE:

Will modify as @polarian suggested.

Unknown commented 1 year ago

Thanks Robin, shouldn't be a big change, a simple if statement :)

Robin Shen changed state to 'Closed' 1 year ago
Previous Value Current Value
Open
Closed
Robin Shen commented 1 year ago

Tracked via issue #1214 Closing this now.

issue 1 of 1
Type
Question
Priority
Normal
Assignee
Issue Votes (0)
Watchers (4)
Reference
onedev/server#1207
Please wait...
Page is in error, reload to recover